The default value for the opening hours instance popup for the weekly repeat is not by default shown for repeated weeks' day, Instead it display repeat value default "never" !

CommentFileSizeAuthor
#5 default-repeat-rule-2297063-5.patch2.46 KBmiteshmap
#3 default-repeat-rule-2297063-2.patch1.97 KBmiteshmap
#1 default-repeat-rule-2297063-1.patch1.44 KBmiteshmap
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

miteshmap’s picture

miteshmap
Primary language Gujarati
CreditAttribution: miteshmap commented
FileSize
default-repeat-rule-2297063-1.patch1.44 KB

Here is the patch of this fix.

(patch created at Coworks)

miteshmap’s picture

miteshmap
Primary language Gujarati
CreditAttribution: miteshmap commented
Status: Active » Needs review
miteshmap’s picture

miteshmap
Primary language Gujarati
CreditAttribution: miteshmap commented
FileSize
default-repeat-rule-2297063-2.patch1.97 KB

With repeat weekly forever option.

(patch created at Coworks)

miteshmap’s picture

miteshmap
Primary language Gujarati
CreditAttribution: miteshmap commented
miteshmap’s picture

miteshmap
Primary language Gujarati
CreditAttribution: miteshmap commented
FileSize
default-repeat-rule-2297063-5.patch2.46 KB

(patch created at Coworks)

mikl’s picture

mikl CreditAttribution: mikl commented
Status: Needs review » Needs work

I don't think this is the right approach. It's not every copy of the repeat rule that repeats, only the first, original one.

It might make more sense to add a message saying something like “This is a copy of a repeating interval. Click here to edit the original interval”.

And as far as the “forever” option, that's not really practical either, since it would potentially create an infinite number of copies of the interval. Setting the end ten years into the future should be sufficient for most use cases.