[D7] Link Field Formatter

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmandarmbhagwat7822942...

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello there,

Automated Review

http://pareview.sh/pareview/httpgitdrupalorgsandboxmandarmbhagwat7822942...
There are a lot of problems.

Manual Review

Individual user account

Yes

No duplication

Yes/No, I'm not sure, there are similar, but not so comprehensive function

Master Branch

No

Licensing

Yes

3rd party code

Yes, Not 3rd party code

README.txt

No, Please refer to the README.txt Template

Code long/complex enough for review

Yes

Secure code

Yes

1, Add new field, input title is "drupal", url is "http://www.drupal.org"， in the “manage display” page, use FORMAT is "Embedded Google Docs viewer",
view the node full page, error is "Notice: Undefined index: filename in link_field_formatter_field_formatter_view() (line 169 of D:\usr\drupal7\sites\all\modules\link_field_formatter\link_field_formatter.module).
The file () is not publicly accessable. It must be publicly available in order for the Google Docs viewer to be able to access it."

2, Ditto, input the url is like "https://www.drupal.org/sites/all/themes/bluecheese/images/sprites.png", use FORMAT is "image",
error is "( ! ) Fatal error: Call to undefined function url_encode() in D:\usr\drupal7\sites\all\modules\link_field_formatter\link_field_formatter.module on line 194"

3, Git repository is http://git.drupal.org/sandbox/mandarmbhagwat78/2294289.git.

Removing PAReview: review bonus. Looks like it was added by mistake by a reviewer.

And while I am at it:

Master Branch

No.

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

It looks good to me now.

Please fix the multitude of issues coming up in PAReview.sh

http://pareview.sh/pareview/httpgitdrupalorgsandboxmandarmbhagwat7822942...

Things that got my attention right away;

• Please update the project info to include the following line:
• GIT: git clone --branch 7.x-1.x http://git.drupal.org/sandbox/mandarmbhagwat78/2294289.git link_field_formatter
• As willietse metioned, the README.txt misses information
• Introduction
• Requirements
• Recommended modules
• Installation
• Configuration
• Troubleshooting & FAQ
• Maintainers

PAReview:

• Test result

Coder review (using the minor (most) option to see everything.

• link_field_formatter.module (a few forgotten spaces and some improper indentation
• Lines 21, 29, 56, 74, 178: Use an indent of 2 spaces, with no tabs (so they all line up).
• Lines 110, 133, 171: Control statements should have one space between the control keyword and opening parenthesis.
• You should have a space after the 'switch' or the 'if'

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.