There is old D-7 style t() still exist in NegotiationSessionForm, NegotiationSelectedForm and NegotiationUrlForm
in language module. It should be $this->t() as per Drupal-8 standards.

Submitted the patch for the same.

CommentFileSizeAuthor
#2 2293779-old-t-function-in-language-forms-2.patch9.73 KBpcambra
old-t-function-in-language-forms.patch9.42 KBjoshi.rohit100

Comments

dawehner queued old-t-function-in-language-forms.patch for re-testing.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
StatusFileSize
new 2293779-old-t-function-in-language-forms-2.patch9.73 KB

Rerolling this one as well.

keopx’s picture

keopx
Primary language Basque
Location Basque Country
commented
Status: Needs review » Reviewed & tested by the community

Patch works fine for me https://www.drupal.org/node/2293779#comment-9077429

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice clean-up.

Committed and pushed to 8.x. Thanks!

  • webchick committed 4ed1db5 on 8.0.x 
    Issue #2293779 by pcambra, joshi.rohit100: Fixed Old t() method in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.