I'd like to test SMS Framework on a d8 core. Anybody could get some help to port this module? Thanks in advance.

CommentFileSizeAuthor
#2 port_to_d8-2291977-1.patch.error_.txt11.22 KBAnonymous (not verified)
#1 port_to_d8-2291977-1.patch6.63 KBalmaudoh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

almaudoh’s picture

Status: Active » Needs review
FileSize
6.63 KB

Here's a patch that ports to D8 compatible with current HEAD on SMS Framework 8.x-1.x

Anonymous’s picture

patch doesn't apply against sms_simplegateway-7.x-1.x-dev.tar.gz, here is the error.

Anonymous’s picture

sorry my fold, I had some problem to apply the patch, I just applied succesfully. I'll test asap.

Anonymous’s picture

ciao almaudoh,
when I try to register the mobile number I get this error.

Fatal error: Call to undefined function drupal_http_request() in /Users/krot/Sites/rezzoli/subdomains/drupal8/modules/sms_simplegateway/sms_simplegateway.module on line 238
Call Stack
# Time Memory Function Location
1 0.0002 246176 {main}( ) ../index.php:0
2 0.0075 882408 drupal_handle_request( ) ../index.php:17
3 0.1380 12726944 Drupal\Core\DrupalKernel->handle( ) ../bootstrap.inc:1388
4 0.1480 13464656 Drupal\Core\HttpKernel->handle( ) ../DrupalKernel.php:306
5 0.1481 13466200 Symfony\Component\HttpKernel\HttpKernel->handle( ) ../HttpKernel.php:44
6 0.1481 13466696 Symfony\Component\HttpKernel\HttpKernel->handleRaw( ) ../HttpKernel.php:66
7 0.2670 22479888 call_user_func_array ( ) ../HttpKernel.php:126
8 0.2670 22480360 Drupal\Core\Controller\HtmlPageController->content( ) ../HttpKernel.php:126
9 0.2670 22480456 Drupal\Core\Controller\HtmlPageController->getContentResult( ) ../HtmlPageController.php:53
10 0.2671 22480968 call_user_func_array ( ) ../HtmlPageController.php:76
11 0.2671 22481568 sms_user_settings( ) ../HtmlPageController.php:76
12 0.2962 25829144 Drupal\Core\Form\FormBuilder->getForm( ) ../sms_user.module:195
13 0.2975 25923336 Drupal\Core\Form\FormBuilder->buildForm( ) ../FormBuilder.php:168
14 0.3731 26584992 Drupal\Core\Form\FormBuilder->processForm( ) ../FormBuilder.php:250
15 0.4062 26628736 Drupal\Core\Form\FormSubmitter->doSubmitForm( ) ../FormBuilder.php:562
16 0.4062 26628784 Drupal\Core\Form\FormSubmitter->executeSubmitHandlers( ) ../FormSubmitter.php:56
17 0.4062 26629560 call_user_func_array ( ) ../FormSubmitter.php:132
18 0.4062 26629632 Drupal\sms_user\Form\SettingsAddForm->submitForm( ) ../FormSubmitter.php:132
19 0.4066 26629720 sms_user_send_confirmation( ) ../SettingsAddForm.php:74
20 0.6430 28352280 sms_send( ) ../sms_user.module:234
21 0.6538 28405024 sms_simplegateway_send( ) ../sms.module:104

Anonymous’s picture

sorry again, it seems the patch wasn't properly applied. I patched manually the module files and now I successfully registered mobile phone number. I'm now ready to test the port.

Anonymous’s picture

pls commit the patch and create a 8.x branch. thanks.

Anonymous’s picture

Status: Needs review » Reviewed & tested by the community

alansaviolobo’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.