Needs review
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Jun 2014 at 08:58 UTC
Updated:
6 May 2019 at 00:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerInteresting!
Comment #2
infojunkiePatch attached.
Comment #3
infojunkieComment #4
dawehnerGiven that we have to port this patch to Drupal 8 we need some kind of test and some point. Do you have the time to write one? Not sure though whether there exists one for display handlers in D7 already tbh.
Comment #5
infojunkieWe need this patch for the module Views Label Tooltip to work correctly in translation, and for any future field "extender" as described here: http://thereisamoduleforthat.com/content/recipe-extending-views-handlers...
I can write a test for D7 if that helps.
Comment #6
infojunkieAdded test to patch. Test fails when
views_plugin_displayis not patched.Comment #7
infojunkieComment #8
infojunkieComment #9
berliner commentedIs there any reason why the test doesn't run?
Comment #10
berliner commentedComment #11
berliner commentedComment #12
stefan.r commentedreuploading the previous patch
Comment #13
chris matthews commentedThe 3 year old patch in #12 does not apply to the latest views 7.x-3.x-dev and if still relevant needs to be rerolled.
Comment #14
andrew answer commentedPatch rerolled.
Comment #15
andrew answer commentedBy unidentified reason CI system don't create test files from patch. Anybody can help?
Comment #16
mustanggb commentedMalformed patch, new files should look something like:
Comment #17
damienmckennaRerolled again.