Problem/Motivation

By upgrading the tests early, we can do some test-driven development toward D8.

Proposed resolution

Do a standard upgrade of the tests.

Remaining tasks

  • Move each test class to a separate file in src/Tests.
  • Upgrade each test. Fix fatal errors caused by variable_set, etc.
  • Move the cas_test module into tests/modules/cas_test and upgrade it.

Reviewer tasks

Reviewers, in addition to normal reviews, the following items need your attention.

  • Ensure class comments are correct.
  • Ensure no tests were overlooked in the upgrade.
  • Execute the tests, looking for test upgrade problems (like deprecated functions and usages).

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 2286703-1-do-not-test.patch32.14 KBcilefen
#2 interdiff-1-2.txt422 bytescilefen
#2 2286703-2-do-not-test.patch32.14 KBcilefen
#3 interdiff-2-3.txt1.45 KBcilefen
#3 2286703-3-do-not-test.patch32.17 KBcilefen

Comments

cilefen’s picture

cilefen commented
Priority: Normal » Major
Issue summary: View changes
StatusFileSize
new 2286703-1-do-not-test.patch32.14 KB
cilefen’s picture

cilefen commented
StatusFileSize
new 2286703-2-do-not-test.patch32.14 KB
new interdiff-1-2.txt422 bytes
cilefen’s picture

cilefen commented
StatusFileSize
new 2286703-3-do-not-test.patch32.17 KB
new interdiff-2-3.txt1.45 KB
  • Deliberately restored a call to the deprecated user_save() because I don't know how the cas_user property is going to be modeled in this module in 8.x.
  • Changed a single updated variable_set as \Drupal::config() with the correct namespace. Use it as a model for upgrading the others.
bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Active » Closed (fixed)

Oof this is an old issue that I forgot about. Long story short, we re-wrote all the tests to be more compatible with the new code. This issue is no longer relevant.