Missing "Save" button on shortcut links list.

What? You want to both re-order that list AND save it? :)

Seriously though, good catch. This is a simple oversight by someone and really glad it's fixed. Thanks for the patch.

Nice work!
This needs a web test to prevent further regressions.

Here is the outline of the WebTest, its not working yet but I am posting what I have got, in the hope, that I have done something trivially silly and someone can point out my shame in 2 seconds flat!!!

The Test:-

1) login with correct previlages
2) post to relevant page
3) look for HTML 200 status code
3) look for green message lable text on returned page

Not quite sure why it is failing .... through web browser testing it fail to return stop ... debugging fails to hit my breakpoints.
At this point I just want to see what testbot says.

Please don't be fooled by the passing tests.

the new test \Drupal\shortcut\Tests\Form\SetCustomizeFormTest does not appear in the test results.. I will look at this again soon

Although the test is run by

php core/scripts/run-tests.sh --php /Applications/MAMP/bin/php/php5.5.10/bin/php --color --die-on-fail --url http://dev.drupal.co.uk --verbose --file ./core/modules/shortcut/tests/src/Form/SetCustomizeFormTest.php

Related #1991104: Shortcut links can't be modified before saving a shortcut set (causes shortcuts in the toolbar to appear in alphabetical order) - even when there's save button, updating the order is not reflected in the shortcut bar - but shouldn't be necessarily fixed here.

Rerolled but without tests - I would fix those in #1991104: Shortcut links can't be modified before saving a shortcut set (causes shortcuts in the toolbar to appear in alphabetical order) because there's a deeper problem with weights.

Added basic test coverage for the shortcut set customize (list links) page.

Leaving testing of the shortcut order to #1991104: Shortcut links can't be modified before saving a shortcut set (causes shortcuts in the toolbar to appear in alphabetical order) per #8 and #10.

Looks good. For the next 6 hrs:
http://s16e60d111f974c3.s2.simplytest.me/admin/config/user-interface/sho...

Committed f48f760 and pushed to 8.0.x. Thanks!