Changes to the Add Content links in the related issues require some updates to the Panopoly widgets stylesheet.

Comments

cboyden’s picture

Component: Widgets » Magic
Status: Active » Needs review
StatusFileSize
new3.55 KB

Styling happens in panopoly_magic/css/panopoly-modal.css. Patch attached. This patch depends on all of the ctools and Panels patches being in place - do not apply until after you've applied those. See Meta issue to get a list of related issues with patches.

cboyden’s picture

Assigned: cboyden » Unassigned
mgifford’s picture

These all look like great improvements for keyboard only users. Great stuff!

dsnopek’s picture

Title: Update styling for Add Content links » Update styling for Add Content links for accessibility changes
dsnopek’s picture

Status: Needs review » Needs work
StatusFileSize
new14 KB
new13.95 KB

Unfortunately, this changes the visual appearance of these buttons.

Here's what it looked like before:

Here's what it looks like after:

I know they are one single link - however, it'd be great it could continue looking the same as it did before!

dsnopek’s picture

Adding the issue this depends on.

cboyden’s picture

It should be doable to recreate the original look of the add content icons, but if you're OK with a change, I think the UI is clearer in the patch. The icons are not separate items from the text buttons, they are part of the same function.

cboyden’s picture

Status: Needs work » Needs review
dsnopek’s picture

Well, I think the icons look better on a white background. Mostly, it's the inconsistent use of white/transparent in the icons. For example, the "Add file" icon is transparent so it now looks grey, which kind messes up the idea that it's a peice of paper. Then on the last three ("Add submenu", etc) it does use a white background, which looks better, but the first two ("Add submenu" and "Add content list") have no boundary between the white and grey which makes them look like there isn't enough padding or that there should be a border.

The alternative would be tweaking the icons look good on the grey, but my guess is that changing the CSS to return to the old design would be quicker?

dsnopek’s picture

Status: Needs review » Needs work

Setting back to "Needs work" because we need to either (1) return to old design or (2) tweak the icons to look better on a grey background.

cboyden’s picture

Status: Needs work » Needs review
StatusFileSize
new3.93 KB

The images themselves don't need tweaking if you set the CSS background of the image tag. The problem with having the gradient background only on the text buttons is that this would be set on the span, not the link. The span isn't - and shouldn't be - focusable, so the hover effect would not appear on keyboard focus.

Updated the patch to set background and border effects on the img.

dsnopek’s picture

Status: Needs review » Fixed
StatusFileSize
new11.93 KB

For history, this is what the buttons look like with the latest patch:

Looks great! This is totally acceptable to me. :-) Committed!

  • Commit 16a217b on 7.x-1.x by dsnopek:
    Update Panopoly Magic for #2283289 by cboyden: Update styling for Add...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.