Changes to the Add Content links in the related issues require some updates to the Panopoly widgets stylesheet.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | Selection_114.png | 11.93 KB | dsnopek |
| #11 | panopoly-magic-add-content-styles-2283289-11.patch | 3.93 KB | cboyden |
| #5 | Selection_113.png | 13.95 KB | dsnopek |
| #5 | Selection_112.png | 14 KB | dsnopek |
Comments
Comment #1
cboyden commentedStyling happens in panopoly_magic/css/panopoly-modal.css. Patch attached. This patch depends on all of the ctools and Panels patches being in place - do not apply until after you've applied those. See Meta issue to get a list of related issues with patches.
Comment #2
cboyden commentedComment #3
mgiffordThese all look like great improvements for keyboard only users. Great stuff!
Comment #4
dsnopekComment #5
dsnopekUnfortunately, this changes the visual appearance of these buttons.
Here's what it looked like before:
Here's what it looks like after:
I know they are one single link - however, it'd be great it could continue looking the same as it did before!
Comment #6
dsnopekAdding the issue this depends on.
Comment #7
cboyden commentedIt should be doable to recreate the original look of the add content icons, but if you're OK with a change, I think the UI is clearer in the patch. The icons are not separate items from the text buttons, they are part of the same function.
Comment #8
cboyden commentedComment #9
dsnopekWell, I think the icons look better on a white background. Mostly, it's the inconsistent use of white/transparent in the icons. For example, the "Add file" icon is transparent so it now looks grey, which kind messes up the idea that it's a peice of paper. Then on the last three ("Add submenu", etc) it does use a white background, which looks better, but the first two ("Add submenu" and "Add content list") have no boundary between the white and grey which makes them look like there isn't enough padding or that there should be a border.
The alternative would be tweaking the icons look good on the grey, but my guess is that changing the CSS to return to the old design would be quicker?
Comment #10
dsnopekSetting back to "Needs work" because we need to either (1) return to old design or (2) tweak the icons to look better on a grey background.
Comment #11
cboyden commentedThe images themselves don't need tweaking if you set the CSS background of the image tag. The problem with having the gradient background only on the text buttons is that this would be set on the span, not the link. The span isn't - and shouldn't be - focusable, so the hover effect would not appear on keyboard focus.
Updated the patch to set background and border effects on the img.
Comment #12
dsnopekFor history, this is what the buttons look like with the latest patch:
Looks great! This is totally acceptable to me. :-) Committed!