Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.There are a couple of accessibility issues in the links on the Add Content overlay:
- The icon and text are seperate but linked to the same thing, causing them to read twice in the screenreader
- The title text for the icons representing the Panopoly custom widgets is identical for the first 8 (out of 11) widgets. Alt is empty and title is "Create a new custom entity."
Fixing this depends on patches to Panels, Ctools and Fieldable Panel Panes, as well as some minor changes to our FPP definitions in panopoly_widgets.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | panopoly-widgets-description-2280887-10.patch | 3.29 KB | cboyden |
Comments
Comment #1
mgiffordCan you provide a sample of the html? Makes it easier to search for.
Comment #2
dsnopekThere are patches on this issue #2280875: Add icon+text renderer to avoid duplicate links for text and icons in Panels IPE, which @japerry is OK with committing to CTools and Panels. For me that's enough to get the patches added to Panopoly and start testing! I'll commit this soon.
Comment #3
cboyden commentedThese are defined in panopoly_widgets.module, so moving the issue there. The function panopoly_widgets_entity_info_alter() loops through all of the widgets and sets the title, path, and image for each one. I'm working on a patch to add a description here.
That said, it looks like the fieldable_panels_panes module does not allow overriding of the description - the description is hardcoded, as opposed to the title etc. For example the line that sets the category is:
'category' => !empty($info['pane category']) ? $info['pane category'] : t('Fielded panes'),but the line that sets the description is:
'description' => t('Create a new custom entity.'),See fieldable_panels_pane.inc, function _fieldable_panels_panes_default_content_type().
I still have some more testing to do before posting a patch.
Comment #4
cboyden commentedComment #5
dsnopekOk! We'll wait until all the patches to fix this whole issue are ready before committing. I was just excited to get the Panels/CTools stuff from the sprint in. :-)
Comment #6
cboyden commentedThe Panopoly patch for this issue will depend on Fieldable Panels Panes allowing the description to be customized. See issue #2283263.
Comment #7
cboyden commentedThis patch adds a description to each of the custom entity types defined in panopoly_widgets.module. I believe it needs an update hook, though. The patch had no effect until I blew away the DB and ran the full install again. Where is this data stored in the DB? Or am I mistaken and is a cache clear or rr all that I need?
Also, someone other than me needs to finalize the exact wording for each widget description.
As noted above, the patch won't have any effect without the FPP patch in the related issue. But it doesn't do any harm if the other patch isn't there.
Comment #8
mgiffordSo your patch just adds titles to the links with further descriptive elements.
Clearing the cache should work... In D7 you had to go to the Theme pages sometimes to deal with cached theme pages. Drush has changed too for Drupal 8.
Moving this to Needs work as you need someone to write descriptive text for the following:
Comment #9
cboyden commentedComment #10
cboyden commentedComment #11
dsnopekAdding the related Panels issue too.
Comment #12
dsnopekComment #14
dsnopekEverything looks good and worked in my testing! Committed. :-)
Work should now continue in this follow-up to get the styling right for these changes:
#2283289: Update styling for Add Content links for accessibility changes
Comment #15
dsnopekHere's another follow-up issue with some styling that this broke: #2287315: "Add" button styling broken on "Add content" dialog
Comment #16
mgiffordVery impressive the speed that these issues have been fixed!
Comment #17
dsnopek@mgifford: It's thanks to UC Berkeley and @cboyden for their committment to accessibility. :-)