Closed (fixed)
Project:
Rules
Version:
8.x-3.x-dev
Component:
Rules Core
Priority:
Major
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
6 Jun 2014 at 09:57 UTC
Updated:
28 Dec 2017 at 16:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
BigEngland commentedComment #2
fagoComment #3
omissis commentedComment #4
omissis commentedHi, I have published a first draft of this ticket implementation in the following PR: https://github.com/fago/rules/pull/106
It's not complete yet, but it represents a starting point for further discussions, as I have a few questions(see on the PR comment).
Comment #5
dasjoupdating the status to reflect the state of the pull request
Comment #6
dasjoI'm unassigning this for now, feel free to pick it up whenever you have time to work on it.
Cheers, dasjo
Comment #7
dasjoComment #8
amerie commentedComment #9
amerie commentedI am not sure of the status of this issue based on the discussion in the pull request, but here is a simple, direct port of the "Text comparison" condition from Drupal 7 (based on the existing D8 "Data Comparison" condition).
Comment #10
fagoWhile I think we want to replace this functionality with #2681735: Add support for data matcher plugins, I think it's fine to complete this to have the functionality ported and working for now. Or do we want to avoid having this condition in the first place, so we do not have to keep supporting it during updates?
Comment #11
klausiI didn't see any progress on the data matcher stuff so I think we should have a straight port of this functionality first. Let's worry about update path before beta.
Comment #12
rooby commentedBased on previous comments, setting to needs review.
Comment #13
rooby commentedI have a rule where on user login it runs a condition where it checks the current page path using this plugin and then fires a redirect action.
When I log in and it runs I get:
Clearing the cache doesn't help.
Comment #14
rooby commentedIt seems that error was somehow related to my doing a config import from development to staging.
I'm pretty sure I did a 'drupal cache:rebuild' before running the config import but it didn't seem to help.
After clearing the cache from the performance UI it all seems to work again.
Comment #15
klausiA test case is missing and please file a pull request against https://github.com/fago/rules/pulls
Comment #16
tr commentedI will write the test.
Comment #17
tr commentedHere is a patch containing:
Comment #18
tr commentedRemoved the unused 'use' statement.
Comment #19
fagooh yes, let's do not wait for this...
Patch is good and has test coverage.
Comment #21
fago