Add discount postprocess hook

I just applied the patch but I don't see any change of the behavior. Do I have to change the price calculation rules order in any way?

This is what I get now:

Product price: 100€ (including 19% tax)
Discount: 10% (= 10€)
Calculated tax on checkout: 15,97€ (should be 14,37€)

If I weight the tax calculation rule higher than the dicount rule, then I get the correct tax (14,37€) but the displayed discount is only 8,40€ instead of 10€.

Hi Axel,

thank you. Unfortunately I'm using commerce_tax and not commerce_vat. Bad luck...I'll try to test it before DC next week.

hi. thanks a lot for your patches. I had no problem to apply the patches to the vat commerce module. But the patch here (commerce_discount-2276335-1.patch) cannot be applied to current 7.x-1.x-dev. It seems more that the current 7.x-1.0-alpha4 and not 7.x-1.x-dev is the destination file.
Thanks in advance!

@axel.rutz this seems like the answers to my prayers... just want to confirm the intent. If I wanted to make this pricing component of the discount non-inclusive in the line item's amount would this be where I should do the modifications?

Maybe something like this could be added to the api docs?

/**
 * Implements hook_commerce_discount_line_item().
 */
function hook_commerce_discount_line_item($line_item_wrapper, $discount_name) {
  // Bail out, no components to modify.
  if (is_null($line_item_wrapper->commerce_unit_price->data->value())) {
    return;
  }
  $data = $line_item_wrapper->commerce_unit_price->data->value() + array('components' => array());
  foreach ($data['components'] as $base_key => $base_component) {
    if (strpos($base_component['name'], 'discount|') === 0) {
      $data['components'][$base_key]['included'] = FALSE;
    }
  }
  $line_item_wrapper->commerce_unit_price->data = $data;
}

The the discount $type would be a bit more useful in my case than the $discount name. Though also the discount name is strange that it's not the machine name...

Testbot

testbot is being nice, retest

just a reroll to see if testbot likes it better.

I've since found a different workaround for the use-case I mentioned in #10.

This needs a reasonable use-case added to the issue summary and just a general issue summary cleanup, hopefully using the template. @see https://www.drupal.org/issue-summaries or use dreditor has a button for that.

Thanks for the re-roll @discipolo

@axel.rutz could you update the issue summary to explain how this is useful for VAT. Please explain how modifications in a post process hook will or could be used for VAT.

I've put markers and cleaned up the issue summary to help you out with the template from http://dreditor.org

This needs documentation.

I've updated this patch so that it also lauch the postprocess hook after free_shipping, percent_off_shipping & shipping_upgrade price components have been added.

This was necessary for me to calculate negative tax on free_shipping price components.