IP2Location is a non-intrusive geo IP solution to help you to identify visitor's geographical location, i.e. country, region, city, latitude, longitude, ZIP code, time zone, connection speed, ISP and domain name, IDD country code, area code, weather station code and name, and mobile carrier, elevation, usage type information using a proprietary IP address lookup database and technology without invading the Internet user's privacy. This module is using IP2Location database to lookup for visitor location and insert the variables into HTTP headers. Other developers can use these variables to customize their content based on visitor location.

About
This is a D7 module. It basically insert geolocation information into HTTP headers to these values can be used in other module, plugins, and themes.

Project Page
https://drupal.org/sandbox/hexasoft/2050979

Git

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/hexasoft/2050979.git ip2location_module

Automated Review
http://pareview.sh/pareview/httpgitdrupalorgsandboxhexasoft2050979git

Comments

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxhexasoft2050979git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

keopx’s picture

Hi

You never close any file on drupal ... "?>" This is very important.

You need 7.x branch into git repository and delete master branch.

Clear unnecessary commented code at line 65-73 to includes/ip2location.admin.inc and don't respect indentation on line 45.

License.txt is agreed by drupal, you don't need it.

In general you need review coding standards https://drupal.org/node/318

hexasoft’s picture

Status: Needs work » Needs review

Codes has been cleaned up and following Drupal standards.

gisle’s picture

Duplication
There is already exists a lot of location modules for Drupal. Here is a list with those I am aware of:

Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Unless you can argue that your module is unique and cannot be fitted into one of the efforts listed above, please open an issue in the most relevant issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

Git Clone Command
Your git clone command still refers to the "master" branch. Also, your git clone command is for you, and will not work for others.
gisle’s picture

Status: Needs review » Needs work

Changing status.

hexasoft’s picture

@gisle

We agree of the non-duplication and non-fragmentation policy by Drupal. This IP2Location module is no duplication compare to existing geolocation modules. We are geolocation service provider and thus publishing this module directly to prevent fragmentation by non-service providers.

We, IP2Location, are one of the pioneer of IP geolocation providers since 2002. The IP2Location LITE is a free database which allows Drupal users to download and install the database in their web site. The IP2Location module is designed efficiently to work with IP2Location LITE. It is more reliable compare to separate modules if supported by 3rd party programmers. In this case, we can support the non-fragmentation strategy of Drupal.

The IP2Location module will be able to let others Drupal users to access to the following information by IP address. We do not see any duplication in term of granularity in other modules.

a)country, b)region, c)city, d)latitude & longitude, d)ZIP code, e)time zone, f)connection speed, g)ISP, h)domain name, i)IDD country code, j)area code, k)weather station code and name, l)mobile carrier, m)elevation, n)usage type

Please let us know if there is any further clarification required. We will be glad to answer those questions.

hexasoft’s picture

Status: Needs work » Needs review
gisle’s picture

@hexasoft, I appreciate you taking the time to explain in #6 why your location module is different from the others.

And while possible overlap of functionality may not be a blocking issue, we require as a minimum that users should be informed about possible functional overlap so that they can make the best choice when looking for a location module. Please take a moment and create a section with the heading "Similar projects and how they are different" on the project's project page where you:

  1. acknowledges the existence of similar projects; and
  2. briefly explain how they are different.

PS: Your git clone command still refers to the "master" branch. Also, your git clone command is for you, and will not work for others.

hexasoft’s picture

@gisle

We have updated the description to acknowledge ourselves as from IP2Location and provided the details of the features that make us different from the other providers.

In addition, we have remove the "master" branch. Can you please review again?

gwprod’s picture

Your git command

git clone --branch master hexasoft@git.drupal.org:sandbox/hexasoft/2050979.git 

still refers to master and is your personal git command, not one usable by others.

hexasoft’s picture

Issue summary: View changes
gwprod’s picture

Please change your git command to

git clone http://git.drupal.org/sandbox/hexasoft/2050979.git

hexasoft’s picture

Issue summary: View changes
coderider’s picture

please follow this https://www.drupal.org/coding-standards

coderider’s picture

Status: Needs review » Needs work
hexasoft’s picture

Status: Needs work » Needs review

Fixed all warnings and errors.

gisle’s picture

Status: Needs review » Needs work

@gisle
We have updated the description to acknowledge ourselves as from IP2Location and provided the details of the features that make us different from the other providers.

Have you? I am unable to find any mention of the other ip2location-projects and what makes you different on the the project page.

Just to spell it out: Your project page is still missing a section where you explain how your IP2location-project is different from all the other IP2location projects that exists.

We require as a minimum that users should be informed about possible functional overlap so that they can make the best choice when looking for a location module. Please take a moment and create a section on your project's project page with the heading "Similar projects and how they are different", where you:

  1. acknowledges the existence of similar projects; and
  2. briefly explain how they are different.

Please see this page for more information.

hexasoft’s picture

Status: Needs work » Needs review

Updated the similar project section. Kindly review.

hexasoft’s picture

May I know how can we proceed further to become a full project? Please advise

naveenvalecha’s picture

Issue summary: View changes

Updated issue summary.

naveenvalecha’s picture

Status: Needs review » Needs work

@hexasoft, Thanks for your contributions.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder.All are fine.
http://pareview.sh/pareview/httpgitdrupalorgsandboxhexasoft2050979git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
May be: Please also specify the differences of the other modules with this module on this page.Does not cause module duplication and fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements
3rd party code
Yes: Follows the guidelines for 3rd party code.
README.txt/README.md
No: Please udpate the Installation section in the Readme.txt and simply write Install as you would normally install a contributed drupal module. See:
https://drupal.org/documentation/install/modules-themes/modules-7
for further information. Follows the guidelines for in-project documentation and the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes. If "no", list security issues identified.
Coding style & Drupal API usage
  1. (*) Update the configure path in the iplocation.info file.
  2. Use drupal_strtolower instead of strolower in function ip2location_fix_case. Same use drupal_strupper instead of strtoupper.
  3. Use Module from the name of the module from ip2location.info file.
  4. I found this function is not used anywhere ip2location_get_header($key) .Please unsed code.

This review uses the Project Application Review Template.

As I am not a git administrator, so I would recommend you, please help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.