Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 May 2014 at 12:43 UTC
Updated:
4 Sep 2014 at 16:24 UTC
Jump to comment: Most recent
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgary2247961git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
brice_gato commentedHello gary1990,
You should change all your drupal_goto, do not use url inside.
drupal_goto(url('user'))use drupal_goto('user').drupal_goto($path = '', array $options = array(), $http_response_code = 302) $path is A Drupal path or a full URL, which will be passed to url() to compute the redirect for the URL.
Comment #3
ameymudras commentedFollowing are the issues that i did find
1. do not put version = 7.x-1.0-alpha1 in the .install file. Drupal by default adds it
2. There is not README.TXT
3. use drupal_goto('user')
4. There are some issues with the coding standards of this module which you can check by using the online application http://pareview.sh/
Comment #4
mgergo90 commentedThank you guys for the review. I've fixed all problems you mentioned.
Comment #5
mgergo90 commentedComment #6
gisleAutomated Review
The automatic review program gets confused because you haven't set up the repo according to convention.
See the notes under Master branch below for details.
Manual Review
If that fails for whatever reason please get back to us and set this back to "needs review"
7.x-1.0-alpha1". This does not follow the guidelines for master branch.. Your master branch should follow the major version branch convention, and be named "7.x-1.x". A correct branch name is required for certain tools to work.Comment #7
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.