This module provides authentication services and an API to perform actions against Google. This module allows users to login to Drupal through the Google Oauth Service.

Features:

-One-click login through Google.
-Automatic import of user e-mail and profile information during initial login.
-Integration with Field module to map Google data to fields on users.
-The ability to de-authenticate or unlink a Google account from a Drupal account.
-Copy profile image from Google account.

Project page:
https://drupal.org/sandbox/gary/2247961

Repository url:
git clone --branch 7.x-1.0-alpha http://git.drupal.org/sandbox/gary/2247961.git google_plus_login

Comments

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxgary2247961git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

brice_gato’s picture

Hello gary1990,
You should change all your drupal_goto, do not use url inside.
drupal_goto(url('user')) use drupal_goto('user').
drupal_goto($path = '', array $options = array(), $http_response_code = 302) $path is A Drupal path or a full URL, which will be passed to url() to compute the redirect for the URL.

ameymudras’s picture

Following are the issues that i did find

1. do not put version = 7.x-1.0-alpha1 in the .install file. Drupal by default adds it

2. There is not README.TXT

3. use drupal_goto('user')

4. There are some issues with the coding standards of this module which you can check by using the online application http://pareview.sh/

mgergo90’s picture

Thank you guys for the review. I've fixed all problems you mentioned.

mgergo90’s picture

Status: Needs work » Needs review
gisle’s picture

Title: Google Plus Login [D7] » [D7] Google Plus Login
Status: Needs review » Needs work

Automated Review

The automatic review program gets confused because you haven't set up the repo according to convention.
See the notes under Master branch below for details.

Manual Review

Individual user account
Yes: The user gary1990 follows the guidelines for individual user accounts.
No multiple applications
Yes
No duplication
No. There already exists a module Google+. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the Google+ issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review"
Master Branch
No: You've named your master branch "7.x-1.0-alpha1". This does not follow the guidelines for master branch.. Your master branch should follow the major version branch convention, and be named "7.x-1.x". A correct branch name is required for certain tools to work.
Licensing
Yes: Follows the licensing requirements
3rd party code
Yes: Follows the guidelines for 3rd party code.
README.txt
No: It exists but does not follow the guidelines for in-project documentation and the README.txt Template.
Code long/complex enough for review
Yes (about 400 lines): Follows the guidelines for project length and complexity.
Secure code
Postponed until duplication issue is sorted out. If "no", list security issues identified.
Coding style & Drupal API usage
Postponed until duplication issue is sorted out
PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.