[D7] Commerce CartaSi XPay

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxbessone1878046git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Tested and fully working

it's working perfectly!

We've been using it since over a year (sandbox version) and it works perfectly.

Note:
This project is using the master branch, not a version specific branch.
It also fails automated testing.

Just sayin.

I'm not going to revert this to 'Needs work', though it does; that is above my paygrade.

This module is riddled with unprocessed $_POST's

I would strongly urge a Git Administrator to review the code themselves before signing off

Regarding #7, have the unprocessed $_POST issues been dealt with or answered to? I will look at the code later - no time right now to dig in deep.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
i couldn't able to clone your module.it asked password while clone.

@viswanathan6: anyone can fix the git clone URL in the issue summary, just take a look at the project git instructions and copy from there: https://www.drupal.org/project/1878046/git-instructions

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Updated the git clone address

While I do feel a little out of my depth doing any review of a money related module from a security perspective the automated review is raising some issues here.

'access callback' => TRUE,

Is there no way you can avoid this being publically accessible?

As the comments do say you require a publically acessible path I'm goint to call this non blocking and as it had been previously set I'm setting it to RTBC, I would suggest the git admins take a quick look from a security perspective though as I feel I'm rather weak here.

You may also want to look into the review bonus program to get it looked at faster.

The directory http://cgit.drupalcode.org/sandbox-bessone-1878046/tree/images in the project repo contains of 3rd party company logos that is both copyrighted and trademarked. Don't even dream about licensing this intellectual property belonging to various third parties under the GPL.

Our policy on 3rd party materials in the repo is described in the 3rd party libraries and content on Drupal.org. It also appears in the Drupal Git Repository Usage policy you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.

Well spotted I read the part in the readme about the icons but totally missed that, no reason they cant be removed and linked to extrnally I woud think.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.