I'm concerned that the translations for the login errors are being forced to include html that is unnecessary and difficult to deal with by translation software. I've included a patch that should clean this up by separating out both strings.

CommentFileSizeAuthor
#2 invalid-login-separate-translations-non-html-2270611_2.patch1.11 KBgeneralconsensus
#1 invalid-login-separate-translations-non-html-2270611.patch1.08 KBgeneralconsensus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

generalconsensus’s picture

generalconsensus CreditAttribution: generalconsensus commented
FileSize
invalid-login-separate-translations-non-html-2270611.patch1.08 KB
generalconsensus’s picture

generalconsensus CreditAttribution: generalconsensus commented
FileSize
invalid-login-separate-translations-non-html-2270611_2.patch1.11 KB

Ignore the first patch, this patch makes the form error consistent with the default drupal form validation error. This will cause the translations to be used by default.

Jerenus’s picture

Jerenus CreditAttribution: Jerenus commented
Status: Needs review » Needs work

Hi generalconsensus,

The patch does't work.

# patch -p1 < invalid-login-separate-translations-non-html-2270611_2.patch

patching file commerce_extra_login_page.panes.inc
Hunk #1 FAILED at 151.
1 out of 1 hunk FAILED -- saving rejects to file commerce_extra_login_page.panes.inc.rej

Thanks,
Jerenus

5n00py’s picture

5n00py CreditAttribution: 5n00py commented
Status: Needs work » Closed (works as designed)

See https://www.drupal.org/node/322774 , here is some info about using html in t() function.
I see that your patch have modification in source string ("email" replaced with "username"), but this is another issue.
If you have problem with this, you can create another issue.