It seems like an oversight, but maybe I am missing something: it seems that the metatag_panels module only does token replacement, not the native panels replacement. The latter is a bit more versatile than tokens in many cases (think: views_context).

Is there a plan to add this?

Any suggestion where this should happen?

I guess somewhere in metatag_panels_ctools_render_alter?

CommentFileSizeAuthor
#4 metatag-n2265453-4.patch2.28 KBdamienmckenna
#1 metatag_panels-ctools-keyword-substitution-2265453.patch1.71 KBzd123

Comments

zd123’s picture

zd123 commented
StatusFileSize
new metatag_panels-ctools-keyword-substitution-2265453.patch1.71 KB

In order for ctools substitution to occur, metatag data must be passed to ctools_context_keyword_substitute() prior to running getElement() on the metatag instance in metatag_panels_ctools_render_alter().

mariusm’s picture

mariusm commented

Superb patch.
Please add to dev

Thanks

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

Need to review it first ;)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n2265453-4.patch2.28 KB

Some small improvements.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks!

  • DamienMcKenna committed 28ce2d3 on 7.x-1.x authored by zd123 
    Issue #2265453 by zd123, DamienMcKenna: CTools keyword substitution for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.