A simple piece of CSS can remove the Flickr title:

span.flickr-title {
display: none;
}

You might prefer to not show a caption under your images, but to respect the Flickr TOS we should keep a link to the corresponding Flickr photo page. If we add a link to Colorbox/Lightbox that would been taken care of.

CommentFileSizeAuthor
#7 exclude_JS_on_admin_pages-2262349-7.patch743 byteslolandese
#3 link_to_flickr_in_colorbox-2262349-3.patch3.42 KBlolandese

Comments

lolandese’s picture

lolandese commented

A bit more elaborated than expected. See https://drupal.org/node/1511472.

lolandese’s picture

lolandese commented

Also note that it would be the only way to comply to the Flickr TOS for Flickr photos that don't have a title (yes, that seems to be possible). We could also skip those.

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new link_to_flickr_in_colorbox-2262349-3.patch3.42 KB

The patch adds a js files that gets loaded only in case of the default style of Colorbox. This covers probably the majority of cases.

Based on:

  • Commit 77dc28d on 7.x-1.x authored by Eric B., committed by lolandese: 
    Issue #2262349 by lolandese: Added link to Flickr to Colorbox's default...
lolandese’s picture

lolandese commented
Status: Needs review » Fixed
lolandese’s picture

lolandese commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Fixed » Patch (to be ported)
lolandese’s picture

lolandese commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Fixed
Related issues: +#1721300: Blocks disregard weight / order assigned to them
StatusFileSize
new exclude_JS_on_admin_pages-2262349-7.patch743 bytes

The added JS mangles the dragging of block weight on admin/structure/block. It won't save a new order after dragging blocks to a new position.

Excluding the JS on admin pages solves the issue, thanks to http://drupal.stackexchange.com/a/35388.

http://cgit.drupalcode.org/flickr/commit/?id=4165b78

Maybe something to look into a bit deeper. Could it interfere with other JS that's not on an admin page? Apart from Colorbox of course on which we want it to act. Maybe the implementation is wrong? Suggestions or comments on this are very welcome.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

lolandese’s picture

lolandese commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Patch (to be ported)
lolandese’s picture

lolandese commented
Status: Patch (to be ported) » Closed (won't fix)

See #2367755: D6 maintenance.

lolandese’s picture

lolandese commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Closed (won't fix) » Closed (fixed)

Setting this back to D7 and being 'fixed (closed)'.

Main reason is the fact that links to this issue show the status on hover without revealing the version (6 or 7). This might give the impression that the mentioned issue will not be solved, while in fact it is already fixed for the D7 version. 'Fixed (closed)' reflects the current status correctly for D7. 'Closed (won't fix)' is only valid for the minimally maintained D6 version of the module.