Problem/Motivation

NodeType, Vocabulary, CustomBlockType, ... duplicate a bunch of code to call the bundle hooks in case they're created/updated/deleted.

Proposed resolution

A common base class would allow us to unify that.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 config-entity-bundle-base-2261369-4-interdiff.txt825 bytesberdir
#4 config-entity-bundle-base-2261369-4.patch8.44 KBberdir
#2 config-entity-bundle-base-2261369-1.patch8.45 KBberdir

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

How about a trait?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new config-entity-bundle-base-2261369-1.patch8.45 KB

That doesn't work, this is all part of the postSave()/postDelete() call chain, we can't do that in a trait. And helper methods would be fairly useless for that, we're talking about 1-3 lines of code for each case, it's nothing complicated, just something that's easily forgotten... Vocabulary is missing delete for example.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented 
  1. +++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityBundleBase.php
@@ -0,0 +1,46 @@
+ * Entity types that what to use this base class must use bundle_of in their
+ * annotation to specify for which entity type they are providing bundles for.

    Entity types that whatwant to use this base class must use bundle_of in their annotation to specify for which entity type they are providing bundles for 

  2. +++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityBundleBase.php
@@ -0,0 +1,46 @@
+  /**
+  /**

    dupes

Other than that, RTBC

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new config-entity-bundle-base-2261369-4.patch8.44 KB
new config-entity-bundle-base-2261369-4-interdiff.txt825 bytes

Yeah, I it was late last night :)

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/lib/Drupal/Core/Config/Entity/ConfigEntityBundleBase.php
@@ -12,13 +12,12 @@
  * annotation to specify for which entity type they are providing bundles for.

I still think the extra 'for' here isn't needed but meh

rtbc if green

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +DX (Developer Experience)

nice clean up

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 177b86e on 8.x by catch: 
    Issue #2261369 by Berdir: Introduce a common config entity base class...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.