Allow multiple local language variations with one single remote language

Added a test for this, as the test failed I created a patch that solves this issue.
I'm still not sure that my fix is the correct option, as I think this mappings should be added automaticaly, without the need of adding it in our custom save, so maybe there's still an error in my schema fix. But I'm not sure if I'm right with it or which should be the correct solution.

There are some leftovers there ;)

Yes, sorry. I was using that to save time, I forgot to delete.

Working for me, seems good.

Done.

Unrelated failing test.

I found an error in the translator test, it was using the local langcode to translate, and it should use the remote langcode, so I fixed.
Now I'm checking that the item is accepted, it contains the translation and the translated language is the correct.

Fixed failing tests.

Missed some tests before.

I don't know why the test fails here and not in local.

Maybe for some strange reason, in the testbot the id is diferent or somthing, so I improved the test, to have dynamic values.

+++ b/src/Tests/TranslatorTest.php
@@ -151,10 +151,15 @@ class TranslatorTest extends TMGMTTestBase {
+    $this->drupalGet('http://d8.dev/admin/tmgmt/items/' . 1);

@@ -162,6 +167,11 @@ class TranslatorTest extends TMGMTTestBase {
+    $this->drupalGet('http://d8.dev/admin/tmgmt/items/' . 2);

Maybe this is a strange reason. :P

yes, lol

Everything works as expected and seems fine to me.

I did because represents that the translator (microsoft, google, gengo...) doesn't know the local language, so has no sense that it shows like it was translated to that language.

ok, done.

Fixed the failing test.

1. +++ b/config/schema/tmgmt.schema.yml
   @@ -39,11 +39,6 @@ tmgmt.translator.*:
        settings:
          type: tmgmt.translator.settings.[%parent.plugin]
   -    remote_languages_mappings:
   -      type: sequence
   -      sequence:
   -        type: string
   -        label: Language key
    
    views.access.tmgmt_job:
      type: mapping
   @@ -55,3 +50,8 @@ tmgmt.translator_base:
   
   @@ -55,3 +50,8 @@ tmgmt.translator_base:
        auto_accept:
          type: boolean
          label: Automatically accept
   +    remote_languages_mappings:
   +      type: sequence
   +      sequence:
   +        type: string
   +        label: Language key
   diff --git a/sources/content/src/Tests/ContentEntitySourceUiTest.php b/sources/content/src/Tests/ContentEntitySourceUiTest.php
   
   diff --git a/sources/content/src/Tests/ContentEntitySourceUiTest.php b/sources/content/src/Tests/ContentEntitySourceUiTest.php
   index b457e4c..001c7a2 100644
   

   I don't get this change.

   We explicitly moved the remote language mappings *out* of the settings. This moves them back in.

2. +++ b/src/Form/TranslatorForm.php
   @@ -233,6 +233,7 @@ class TranslatorForm extends EntityForm {
        $entity = $this->entity;
   +    $entity->setSetting('remote_languages_mappings', $form_state->getValue('remote_languages_mappings'));
   

   Same here. It has to work without this.

   If it does't then we need to identify what code is still trying to access them as settings.

3. +++ b/tmgmt_test/config/schema/tmgmt_test.schema.yml
   @@ -16,8 +16,3 @@ tmgmt.translator.settings.test_translator:
          type: string
          label: Another key
   -    remote_languages_mappings:
   -      type: sequence
   -      sequence:
   -        type: string
   -        label: Language key
   diff --git a/tmgmt_test/src/Plugin/tmgmt/Translator/TestTranslator.php b/tmgmt_test/src/Plugin/tmgmt/Translator/TestTranslator.php
   

   This however is correct and should be removed.

I changed that, because was not working without the point 2. So to make the point to work I had to change the schema.
I don't know how to solve this otherwise.
Why should not be in settings? Isn't it a setting?

I know this fails, it's just to shou it to @Berdir, I don't know why it fails.

I think adding 'remote_languages_mappings' => [] everywhere is not the best solution, but it works, so I upload this to you to check the progres and maybe suggest a better solution.

Fixed those failing tests.

1. +++ b/src/Form/TranslatorForm.php
   @@ -232,14 +232,16 @@ class TranslatorForm extends EntityForm {
       * Overrides Drupal\Core\Entity\EntityForm::save().
       */
      public function save(array $form, FormStateInterface $form_state) {
   +    //$this->entity->set('remote_languages_mappings', $form_state->getValue('remote_languages_mappings'));
        $entity = $this->entity;
        $status = $entity->save();
   +    //$status = parent::save($form, $form_state);
   

   This should be removed.

2. +++ b/src/Form/TranslatorForm.php
   @@ -232,14 +232,16 @@ class TranslatorForm extends EntityForm {
   -      drupal_set_message(format_string('%label configuration has been updated.', array('%label' => $entity->label())));
   +      drupal_set_message(format_string('%label configuration has been updated.', array('%label' => $this->entity->label())));
        }
        else {
   -      drupal_set_message(format_string('%label configuration has been created.', array('%label' => $entity->label())));
   +      drupal_set_message(format_string('%label configuration has been created.', array('%label' => $this->entity->label())));
   

   unnecessary change?

3. +++ b/src/Tests/TMGMTTestBase.php
   @@ -158,6 +158,7 @@ abstract class TMGMTTestBase extends WebTestBase {
          'label' => $this->randomMachineName(),
          'plugin' => 'test_translator',
   +      'remote_languages_mappings' => [],
   

   This should *not* be necessary. If it's not then it means that the property on Translator is not defined. Define it there as an empty array instead.

As I said, that was a patch work in progres, so I had some things that I tried commented just to get feedback about what was better.
Now should be everything ok.

Rebased

+++ b/src/Tests/TMGMTTestBase.php
@@ -158,7 +158,6 @@ abstract class TMGMTTestBase extends WebTestBase {
       'plugin' => 'test_translator',
-      'remote_languages_mappings' => [],
       'settings' => empty($values['plugin']) ? [

Added again this line, is defined but still don't work without this.

We discussed and there is an issue where we will try to fix it #2654958: Default remote language mappings are not recreated
So I'm closing it.