Default remote language mappings are not recreated

Hm, applied easily here. Rerolled..

+++ b/src/Entity/Translator.php
@@ -143,7 +143,7 @@ class Translator extends ConfigEntityBase implements TranslatorInterface {
    */
-  protected $remoteLanguagesMappings = array();
+  protected $remote_languages_mappings = array();

@@ -371,15 +371,15 @@ class Translator extends ConfigEntityBase implements TranslatorInterface {
   public function getRemoteLanguagesMappings() {
-    if (!empty($this->remoteLanguagesMappings)) {
-      return $this->remoteLanguagesMappings;
+    if (!empty($this->remote_languages_mappings)) {
+      return $this->remote_languages_mappings;

This is not correct. the camel case one is a static cache. We already were using the one with underscore before, it just wasn't documented.

mapToRemoteLanguage() then looks again at $this->get('remote_languages_mappings'), that makes no sense like this.

Maybe we no longer need the static or can simplify it elsewhere but this change is definitely not correct.

Is not anymore a property, set to local variable.

We still need to define the actual property remote_languages_mappings like the previous patch did.

Also, would be great to test this. To do this, we need to simulate that a translator doesn't return mappings or they change based on the settings.

I'd be OK if we can write those tests using a remote translator like gengo and simulate this behavior there.

Re-added the property and some clean up.

We tested manually and it works.
We will add tests in this issue #2655948: Add "Connect" button when we release a new version of tmgmt.
The test will consist on open the translator config form check the default mapping, add the auth keys, ajax will refresh with the server values, to pass the test it must show the previous value instead of the empty value '-'.

Thanks committed.