After updating External Links from 7.x-1.16 to 7.x-1.17, all images linking to an external link now have the "external link" icon displayed beside them! Even, if the checkbox "Place an icon next to image external links." at admin/config/user-interface/extlink is kept unchecked.

Sorry for having this issue's priority increased, but with this the sites really may become looking ugly.

CommentFileSizeAuthor
#8 extlink-always-on-images-2257023-8.patch463 bytesjordan8037310

Comments

roball’s picture

roball commented
Title: Images linking to an external link ALWAYS » Images linking to an external link ALWAYS have the "external link" icon displayed
roball’s picture

roball commented
Issue summary: View changes
elachlan’s picture

elachlan commented

Thanks for the bug report. If you resave the config does it fix it? I will have a look as soon as possible.

roball’s picture

roball commented

No, unfortunately re-saving the config form does not help. Thanks for looking into the problem.

elachlan’s picture

elachlan commented
Related issues: +#2243457: CSS exclusion stopped working

I believe it could be caused by this change #2243457: CSS exclusion stopped working.

jordan8037310’s picture

jordan8037310 commented

I also have this issue and resaving the config does not help

jordan8037310’s picture

jordan8037310 commented

Reverting the change at https://drupal.org/node/2243457 does not help.

jordan8037310’s picture

jordan8037310 commented
StatusFileSize
new extlink-always-on-images-2257023-8.patch463 bytes

After reviewing the release notes, I checked out this commited patch as it deals more with the functionality of the image links.

https://drupal.org/node/2255295#comment-8735273

Attached is a patch I made after partially reverting some of the patch above. Fixed this issue for me.

susoson’s picture

susoson commented

Experienced same issue on first install of this module today. Applied patch in above post and problem solved.

wickwood’s picture

wickwood commented

I also had the same issue and the patch in #8 applied to dev version worked for me.

rHOnDO’s picture

rHOnDO commented
Status: Active » Reviewed & tested by the community

Same issue, fixed by patch from comment #8. Installed and configured the module, checked and unchecked the config. Uninstalled and reinstalled module ... fixed when I installed patch.

captaindav’s picture

captaindav commented

We just updated the external links module (only) to 7.x-1.17 on an Omega themed site with graphic images and slides on the front page. After updating the external links module, the page layout (done in Panels) changed with items not wrapping correctly. I assume this is due to this issue.

A-snowboard’s picture

A-snowboard commented

ok for me.

Tank'

elachlan’s picture

elachlan commented
Status: Reviewed & tested by the community » Fixed
roball’s picture

roball commented

Thanks for finally committing this fix. I think this deserves a new release, since this bug may have broken the visible layout of many sites (including some of mine).

elachlan’s picture

elachlan commented

I have created the release. It should be up in a little while.

roball’s picture

roball commented

Thank you elachlan for releasing 7.x-1.18! Now works totally fine :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.