Since 7.x-1.16 exclusion by CSS selectors seems to be broken.
Tested also on a new clean install with just extlink installed. Same problem.
Worked in previous release though.

CommentFileSizeAuthor
#12 extlink-css-exclusion-issue-2243457-12.patch709 bytesherved
#6 extlink-css-exclusion-issue-2243457-6.patch704 bytesherved

Comments

markus_petrux’s picture

markus_petrux commented

Same issue here.

raj.chourasia’s picture

raj.chourasia commented

Same issue

quicksketch’s picture

quicksketch
he/him
commented

Hmm, thanks guys. I would guess it'd be #1329786: JS refactoring or #1206276: Make priority of include and exclude pattern matching configurable that caused this problem, based on the Git history that affected CSS inclusion/exclusion.

Charlesdru’s picture

Charlesdru commented

Same issue

papper00’s picture

papper00 commented

Hi guys, same issue here.

Have overcome the issue by overriding the background and padding styles in my local.css to remove the icon based on the parent elements, which is of course pretty much the same thing!

herved’s picture

herved commented
StatusFileSize
new extlink-css-exclusion-issue-2243457-6.patch704 bytes

I have the same.
Here's a patch I did which seems to solve the issue. Needs review though.

spazfox’s picture

spazfox
Location Olympia, WA
commented

#6 works for me and doesn't appear to break anything!

play4quarters’s picture

play4quarters commented

#6 also working here! Thanks herve001!!

rian76’s picture

rian76 commented

#6 also fixes issue here. Thanks herve001.

herved’s picture

herved commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: extlink-css-exclusion-issue-2243457-6.patch, failed testing.

herved’s picture

herved commented
StatusFileSize
new extlink-css-exclusion-issue-2243457-12.patch709 bytes

Okay... Same patch but using git -_-'

herved’s picture

herved commented
Status: Needs work » Needs review

  • Commit 45a22e1 on 7.x-1.x by quicksketch: 
    Issue #2243457 by herve001 | rian76: CSS exclusion stopped working.

  • Commit 4bf6b43 on 6.x-1.x by quicksketch: 
    Issue #2243457 by herve001 | rian76: CSS exclusion stopped working.
quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Thanks everyone! We really appreciate the testing and patches. Sorry about breaking this. :(

Committed to both branches. I'll be making a new release shortly with this and other fixes included.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.