Our flag confirm form calls field_attach_form(), but then doesn't call the corresponding FieldAPI validation form.

That means that users can enter total rubbish into fields on Flaggings and it won't get validated.

CommentFileSizeAuthor
#8 2254417.8.flag_.missing-field_attach_form_validate.patch7.74 KBjoachim
#1 2254417.flag_.missing-field_attach_form_validate.patch7.59 KBjoachim
#1 2254417.flag_.missing-field_attach_form_validate-tests-only.patch6.26 KBjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 2254417.flag_.missing-field_attach_form_validate-tests-only.patch6.26 KB
new 2254417.flag_.missing-field_attach_form_validate.patch7.59 KB

One patch with tests, one patch with tests + fix.

The last submitted patch, 1: 2254417.flag_.missing-field_attach_form_validate-tests-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 1: 2254417.flag_.missing-field_attach_form_validate.patch, failed testing.

joachim’s picture

joachim commented

!?!!! Tests pass for me locally!!!

joachim’s picture

joachim commented

Just double-checked. Tests pass for me locally, even if I run them on a totally blank Drupal site.

joachim’s picture

joachim commented

Oh hang on! The failing test isn't even touched by this patch!!!

joachim’s picture

joachim commented

Oh DUH this is because the confirm unflag form is getting affected! This is what tests are for :)

joachim’s picture

joachim commented
Status: Needs work » Needs review
StatusFileSize
new 2254417.8.flag_.missing-field_attach_form_validate.patch7.74 KB

Figured it out and fixed it.

joachim’s picture

joachim commented
Status: Needs review » Fixed

  • Commit e5647c9 on 7.x-3.x by joachim: 
    Issue #2254417 by joachim: Fixed Flagging fields in flag confirm form...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.