Follow-up from #2251119: Hovering about display links changes the position.. See screenshots in that issue summary. Look closely at the top of the 2nd display tab.

Before:

After:

Remaining Tasks

  • (novice) create a separate issue per @LewisNyman in #8 [ create separate issue, use issue summary template, make a comment here also ]
CommentFileSizeAuthor
#6 gray-bar-after.png15.74 KBalimac
#6 gray-bar-before.png16.75 KBalimac
#4 views_ui-remove-top-border-2251221-4.patch500 bytesalimac
views-displays-remove-gray-top-border.patch461 byteslokapujya

Comments

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
commented

Oh wow! I guess a proper fix might be to rename the classes used here all together, to not conflict in the first place.

alimac’s picture

alimac commented

@dawehner do you mean rename tabs__tab class to something else?

alimac’s picture

alimac commented
StatusFileSize
new views_ui-remove-top-border-2251221-4.patch500 bytes

I'm wondering whether this fix should go into core/modules/views_ui/views_ui.admin.theme.css instead of core/themes/seven/style.css?

Attaching a patch just in case.

dawehner’s picture

dawehner
Primary language German
commented

@dawehner do you mean rename tabs__tab class to something else?

Yeah exactly.

alimac’s picture

alimac commented
Issue summary: View changes
StatusFileSize
new gray-bar-before.png16.75 KB
new gray-bar-after.png15.74 KB

Added screenshots.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented

@ #2, Maybe we do want to inherit most of the Secondary Tabs rules from the theme, just not the top border.

lewisnyman’s picture

lewisnyman
he/him
commented

hmm the problem is that views was initially tweaking the secondary tabs styling, and the tabs were redesigned but the views design stayed the same. Should the views tabs design stay so different from the rest of the admin UI? That's a discussion for another issue and I think we mentioned this during #1490402: Redesign tabs and the content header.

To fix the reported bug and maintain the current direction, we can just continue to override the CSS in views and remove the top border for now, and then create a follow up to decide how to handle the tabs in views going forward. The patch is RTBC from me.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

My knowledge and level of worrying about CSS is not that high.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: views_ui-remove-top-border-2251221-4.patch, failed testing.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented

4: views_ui-remove-top-border-2251221-4.patch queued for re-testing.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs work » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Oh, nice work. That definitely looks much better. :)

Committed and pushed to 8.x. Thanks!

  • Commit a4bd514 on 8.x by webchick: 
    Issue #2251221 by alimac, lokapujya: Views Display Tabs: remove gray top...
yesct’s picture

yesct commented
Issue summary: View changes
Issue tags: +Novice, +Needs followup
Related issues: +#2251119: Hovering about display links changes the position., +#1490402: Redesign tabs and the content header

added a novice task for creating the follow-up @LewisNyman asked for in #8.
tagging.

----------------------------
also, why are the screenshots broken in this and also #2251119: Hovering about display links changes the position. ?
file is still there: https://drupal.org/files/issues/gray-bar-after.png
and the html in the issue summary looks fine!

trying it here to see...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.