Problem/Motivation

When you hover over one of the views (File Usage in this example):
Example - views buttons
It shifts to the right:
Example - shifted button

Also, it looks like the button that is not highlighted is off vertically.

Proposed resolution

fix it.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#8 views_ui-fix-hover-bug-2251119-8.patch510 bytesalimac
#7 views_ui-fix-hover-bug-2251119-7.patch512 bytesalimac
#6 views_ui-fix-hover-bug-2251119-6.patch512 bytesalimac
#3 views_ui-fix-hover-bug-2251119-3.patch380 bytesalimac
#2 views-ui-2.png18.22 KBalimac
#2 views-ui-1.png18.25 KBalimac
views_ui.png2.83 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
alimac’s picture

alimac commented
Title: Hoving about display links changes the position. » Hovering about display links changes the position.
Issue summary: View changes
StatusFileSize
new views-ui-1.png18.25 KB
new views-ui-2.png18.22 KB

Fixed typo in title and added two screenshots for clarification. I might take a stab at this.

alimac’s picture

alimac commented
Status: Active » Needs review
StatusFileSize
new views_ui-fix-hover-bug-2251119-3.patch380 bytes

Here's a patch that fixes the horizontal shifting on hover.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented

Opened another one for the top gray border: #2251221: Views Display Tabs: remove gray top border.

Should fix "Also, it looks like the button that is not highlighted is off vertically."

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/themes/seven/style.css
@@ -396,8 +396,6 @@ li.tabs__tab a {
-  border-left: 2px solid #008ee6;
-  padding-left: 15px;

I guess this kind of behavior is expected somewhere else in core?

alimac’s picture

alimac commented
StatusFileSize
new views_ui-fix-hover-bug-2251119-6.patch512 bytes

You're right. Here's a patch to views_ui.admin.theme.css that accomplishes the same.

alimac’s picture

alimac commented
StatusFileSize
new views_ui-fix-hover-bug-2251119-7.patch512 bytes

Just noticed that I have a trailing space - fixed in this patch.

alimac’s picture

alimac commented
StatusFileSize
new views_ui-fix-hover-bug-2251119-8.patch510 bytes

Still trailing space in #7 - this should be clean.

The last submitted patch, 7: views_ui-fix-hover-bug-2251119-7.patch, failed testing.

oadaeh’s picture

oadaeh commented

The patch in #8 does indeed correct the errant behavior.

oadaeh’s picture

oadaeh commented
Status: Needs review » Reviewed & tested by the community
lewisnyman’s picture

lewisnyman
he/him
commented

RTBC++

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: views_ui-fix-hover-bug-2251119-8.patch, failed testing.

oadaeh’s picture

oadaeh commented
Status: Needs work » Needs review

Failed on a locale update test? Let's try that again.

oadaeh’s picture

oadaeh commented

8: views_ui-fix-hover-bug-2251119-8.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Just another random fail...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Great catch!

Committed and pushed to 8.x. Thanks!

  • Commit b01eced on 8.x by webchick: 
    Issue #2251119 by alimac | dawehner: Hovering about display links...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.