The contributed sub-modules "event_all_day" and "event_views" are flagged as incompatible with drupal 6.x

The problem seems to be in the *.info lines:
dependencies = event should be: dependencies[] = event
The square brackets are missing.

Note: in "event/contrib/event_all_day/event_views.info" it had an additional problem: It mentions "event views" as a dependency. It should be "views".

CommentFileSizeAuthor
#5 event_contrib_info.patch1.5 KBkonsumer

Comments

Anonymous’s picture

Anonymous (not verified) commented

I think, the last one should be:

dependencies[] = event
dependencies[] = views
drdrup’s picture

drdrup commented

ohhhh! I probably misread the line. Now I see it: it probably depends both on "event" and on "views" (and I don't read php yet, so I don't know what really is needed), so you are right.

I couldn't find where are the instructions for *.info files for Drupal 6. I just saw "Writing .info files (Drupal 5.x)" http://drupal.org/node/101009. Anybody knows where is the one for 6 ?

Anonymous’s picture

Anonymous (not verified) commented

I haven't found the documentation for D6 .info files, too, but there is a how-to for porting D5 modules to D6:

http://drupal.org/node/114774#info

hth

drdrup’s picture

drdrup commented

Thanks. It has a lot of info there.

konsumer’s picture

konsumer commented
StatusFileSize
new event_contrib_info.patch1.5 KB

Attached is a patch for a maintainer that fixes this issue.

konsumer’s picture

konsumer commented
Status: Active » Needs review

forgot to update status

acker’s picture

acker commented
Status: Needs review » Reviewed & tested by the community

Perfect patch, about time this got rolled into the release.

pobster’s picture

pobster commented

It's all well and good making these projects visible, but neither of them work?

I've fixed the all_day module to a point;

/**
 * Implementation of hook_help().
 */
function event_all_day_help($section) {
  switch ($section) {
    case 'admin/modules#description':
      return('All day events');
  }
}

function event_all_day_form_alter(&$form, $form_state, $form_id) {
  $type = (isset($form['type']) && isset($form['type']['#value'])) ? $form['type']['#value'] : NULL;
  if ($form_id == $type .'_node_form' && variable_get('event_nodeapi_'. $type, 'never') != 'never') {
    // add all day checkbox
    $form['event']['start_minute_all_day'] = array(
      '#type' => 'checkbox',
      '#title' => t('All day'),
      '#default_value' => 0,
      '#weight' => -18,
    );

    $path = drupal_get_path('module', 'event_all_day');
    drupal_add_js($path . '/event_all_day.js');
    // theme_add_style($path . '/event_all_day.css');
  }
}

I'm not bothered about Views until it's stable.

Pobster

killes@www.drop.org’s picture

killes@www.drop.org commented

event all day is no longer needed, its functionality is now in the main event module. Event_views needs to be ported.

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Closed (won't fix)

event_all_day is superseded by the "has time" setting. event_views isn't ported yet since views isn't available.