Replace fake mocks with actual OpenDialogCommand stubs in AjaxCommandsTest

+++ b/core/tests/Drupal/Tests/Core/Ajax/AjaxCommandsTest.php
@@ -440,7 +441,7 @@ protected function drupalAttachLibrary($name) {
 /**
  * Wraps OpenDialogCommand::drupalAttachLibrary().
  *
- * {@inheritdoc}
+ * Defines an AJAX command to open certain content in a dialog.

maybe we should look at the usages of TestOpenDialogCommand to help us know what it does and why. (and/or use git blame or git log -S to help us find the issue that put it there. that might also help with it's summary)

We might actually just be able to delete the {@inheritdoc} (and the newline), if the Wraps .... line is sufficient to tell us a one line summary of what this class is doing.

Although the classes it is extending does more than just provide the drupalAttachLibrary()

Since the class is Test...
I kind of expected the docs to mention Tests or testing.

+++ b/core/tests/Drupal/Tests/Core/Ajax/AjaxCommandsTest.php
@@ -332,10 +337,17 @@ public function testOpenDialogCommand() {
    * Tests that OpenModalDialogCommand objects can be constructed and rendered.
    */
   public function testOpenModalDialogCommand() {
...
+      // This method calls drupal_render which isn't available. We want it to do
+      // nothing so we mock it to return null.
+      ->setMethods(array('drupalAttachLibrary'))
+      ->getMock();

the test says it tests if they can be rendered... but the comment sounds like we are not testing that.

Maybe we should update the comment and open an issue to add render testing?

tagging phpunit