The Panopoly 1.3 release failed to build because manualcrop needed some libraries that weren't in the Drupal.org Whitelist, and I forgot to check. So that I can never make this stupid mistake again, let's add this to our Travis-CI tests!

The code will be something like:

drush dl -y drupalorg_drush-7.x-1.x-dev --destination=$HOME/.drush
drush verify-makefile drupal-org.make
find modules/ -name \*.make -exec drush verify-makefile \{\} \;

Note 1: The find bit is required to check all .make files since drush verify-makefile won't recurse into sub-make files, which wouldn't catch the manualcrop issues.

Note 2: I'm not sure the find will correctly return an error code that Travis-CI will detect as failure, so this will need some experimentation. And, unfortunately, I can't do it right now, because the build is broken by Drush installation per an upstream issue: https://github.com/drush-ops/drush/issues/601

Anyway, I'm looking forward to the build pretecting Panopoly from me. :-)

Comments

dsnopek’s picture

lsolesen’s picture

Looks like the issue in Drush has been resolved?

dsnopek’s picture

Yep, the Drush issue is fixed! I'll start working on this issue soon. :-)

  • Commit 80c987e on 7.x-1.x by dsnopek:
    Issue #2248573: Run 'drush make-verify' on Travis-CI to make sure ALL ....
dsnopek’s picture

Status: Active » Fixed

Fix has been committed, which I've tested to fail with the .make files that wouldn't build for Panopoly 1.3. Now all we have to see is if they'll pass with the good .make file. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.