Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.There is a small bug in panopoly_magic css.
The problem is that in some browsers there is no support except Verdana, but because there's no comma between verdana and sans-serif so rendering issues ensue.
ERROR:
font: bold 16px/50px 'Open Sans', 'Lucida Sans', 'Lucida Grande', verdana sans-serif;
CORRECTION:
font: bold 16px/50px 'Open Sans', 'Lucida Sans', 'Lucida Grande', Verdana, sans-serif;
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | panopoly_magic-2246859-.patch | 2.34 KB | cs_shadow |
| #1 | panopoly_magic_invalid_font-2246859-01.patch | 5.39 KB | sylus |
Comments
Comment #1
sylus commentedAttaching patch.
Comment #2
lsolesen commentedThere seems to be some stuff in this patch which has nothing to do with the fonts.
Also, shouldn't the font-family be removed instead and leave that up to the theme?
Comment #3
sylus commentedThe stuff that has nothing to do with the fonts is my IDE sublime correcting some formatting issues primarily extra white space.
This can be fixed in another issue I guess but should also be addressed as makes it hard to provide patches when Drupal coding conventions aren't followed.
Additionally this issue is just to correct an existing bug. We can discuss the merits about removing the font-family entirely but in the mean time this issue should still be fixed.
Comment #4
dsnopek@stylus: There are loads of coding style issues in Panopoly that I'd like to resolve eventually! However, making coding style fixes will break any other existing patches against this file. I want to hold off on coding style fixes until we can get the number of open issues (many of which have patches) down to a more manageble level. Hopefully, the sprint at DrupalCon will help get us closer. :-)
But in the meantime, a patch without coding style changes would be much appreciated!
Comment #5
cs_shadow commentedAttaching a patch which just changes all occurences of
verdana sans-seriftoVerdana, sans-serif.Comment #6
dsnopekThanks, @cs_shadow and @sylus! The patch from #5 has been committed. :-)