Closed (fixed)
Project:
Plupload integration
Version:
2.1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Apr 2014 at 08:15 UTC
Updated:
18 Nov 2023 at 18:19 UTC
Jump to comment: Most recent
Comments
Comment #1
slashrsm commentedComment #2
jcandan commentedThis is still an issue in 2.1.x.
README states that an alternate library location can be set in
settings.php. Changing category to Bug because of the documentation.Note: Since that package doesn't require
composer/installers, we have no way to modify the destination install path for the library (e.g. place it inweb/libraries/{$name}). If this is fixed, it would allow us to require the library via composer, and pointsettings.phpto thevendor/moxiecode/pluploadpath.Comment #3
jcandan commentedThe Chosen module had a similar situation detailed in #3102250. Comment #47 offered a workaround that works for this project.
I was able to require mnsami/composer-custom-directory-installer and simply add an
installer-pathsdirective:Comment #4
jcandan commentedWith this workaround, does the maintainer and/or the community want to:
Or, is it still preferred that this capability be available?
Comment #5
jcandan commentedWe should probably note too that the the examples folder should be removed from production environments.
As per Composer, this should probably be done in a build step.
Comment #6
budalokko commentedI'd rather remove the references to customize
library_path.Did a quick review of other modules in similar situation and nobody cares about library path nowadays, at least at the module level. Maybe this is handled site-wide in some setting related to
"type": "drupal-library",.Regarding the library installation options, we should definitely clarify more modern options that direct download. The mnsami/composer-custom-directory-installer option you suggest seems really similar to the "The composer way #1" in DropzoneJS module. Any idea on which to take?
Comment #7
jcandan commentedI wouldn’t agree that it is all that similar; just another option.
You could document those 2 options as well.
I am persuaded by Dropzone’s #2, since it doesn’t require additional packages and just uses Composer’s repository feature.
Comment #8
budalokko commenteddropzone #2 has the advantage that patches in root composer are applied. So adding our examples patch would be a no-brainer. Not sure about it, but think that merged composer files do not get patches applied.
Will I get any dev-help on these fixes/improvements?
Comment #9
budalokko commentedComment #12
budalokko commentedCreated documentation on how to install via composer:
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib...
Then just forget about setting custom path. /libraries is quite standard.