Closed (fixed)
Project:
Scald: Media Management made easy
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Apr 2014 at 19:27 UTC
Updated:
23 Jul 2015 at 08:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jcisio commentedThanks for the bug report. I track that commit and now we can use the new hook_edit_render_field() instead.
Comment #2
nagy.balint commentedSince then, the edit module was renamed to quickedit.
However it seems to me that the hook_edit_render_field() is for display only, when after an edit the system shows the rendered field, and not related to the ckeditor itself.
Comment #3
trackleft2Any news on updates for this? Quick edit is an easy sell, which in turn sells scald during demos.
Comment #4
nagy.balint commentedUnfortunately they have not responded to my problem in their issue queue.
It seems that we can add the dnd to the edit module, but only without checking if the page even needs a dnd. So it would appear all the time even if you dont have any fields requiring it, since the metadata was removed from that function.
Comment #5
nagy.balint commentedI tried to get this working.
Ckeditor worked fine, however i was unable to include the dnd library no matter which hook i tried to use.
Seems like the new version works quite differently from the old verison.
Comment #6
nagy.balint commentedActually it worked with dnd_quickedit_editor_attachments_alter, however it only loads the js, and not the css so thats why its not visible :(
Comment #7
nagy.balint commentedOn the other hand, as far as i can see the attachment alter will load the library even when i did not trigger the quick edit mode yet.
So we could have an alternative workaround where we include the library on node pages if the quick edit is available for that node and dnd is enabled on one of the fields, but we can do that simply on page load and not through quickedit hooks, and that way it could be more reliable.
Comment #8
nagy.balint commentedSo here is the patch that does #7
Basically checking in an entity_view_alter whether we likely going to need the dnd library or not,
like checking all fields if one of them is atom reference or field with the dnd enabled setting, and some other quickedit specific checks and then includes the library.
And since quickedit is loaded through Ajax, the library will stay and remain operational.
Comment #9
nagy.balint commentedIf anyone is against committing this, let me know.
The hook only does anything when quickedit is enabled, and when there is any chance that it can be needed on a specific piece of entity view. From my tests this workaround worked well.
Comment #10
nagy.balint commentedComment #11
nagy.balint commentedCommitted.