We need to design and develop a user interface through which users will interact with the new testing infrastructure.

Rather than in-line test results, I envision a 'testing block' or something similar that is displayed on a given issue page.

We also need a user interface for testing results on project pages. I anticipate re-purposing the 'automated testing' tab on existing project pages for this.

‘On Demand’ test triggers and User Interface

  • In addition to the ‘automated’ jobs, there will be jobs which will need to be run based on user demand.
  • User-initiated job triggers may be required in a few different locations:
    • Project pages (for project/release level jobs)
      • UI probably accessed via the ‘Automated testing’ tab
      • Job examples:
        • trigger simpletest/phpunit/behat tests for a given release
        • Run through all patches for a given release and ensure they still apply
    • Issue pages (for issue/patch level jobs)
      • UI probably contained within a sidebar block
      • Job examples:
        • trigger simpletest/phpunit/behat tests for a patch
        • Find all patches for a given release which would conflict with this patch (i.e. would need reroll if this is committed)
  • We need both the User Interface design and backend coding for these triggers
  • Actual triggering of a job should leverage the same triggering code as the ‘Automated’ test triggers

Here is the progress so far. For the files tables in issues:
Screenshot

And where "Add test" links to:
Screenshot

Comments

jthorson’s picture

Project: » DrupalCI: Drupal.org Integration (Modernizing Testbot Initiative)
Component: Drupal.org Integration » Code
Mixologic’s picture

Adding this META bluecheese design issue for references: they discuss how the appearance of inline things should be.

Im not sure we can avoid having inline results, as sometimes there is more than one patch at a time being worked on (two different architectural approaches, for example). We'd also want some historical results for older patches that did or didnt pass, so I think that data probably is best kept associated with the patches that are submitted inline as well.

Though I also see major value in having a testing block that gives an overall picture of the issue too...

jthorson’s picture

Also to keep in mind, I migrated the simpletest testing information to a new 'Automated Testing' tab on projects, with the intention that we would further extend and leverage this tab as we enhance the infrastructure. Because it's provided by PIFT, assume we have full control and authority over any UI changes that we might want to land here (within the style guidelines, of course!).

Mixologic’s picture

I migrated the simpletest testing information to a new 'Automated Testing' tab on projects

Right on, I wasnt aware of that.. Is there an example of that somewhere? Im not sure which set of tabs you're referring to.

jthorson’s picture

On any full project, it's the 'automated testing' link ... the one that takes you to node/[nid]/qa for that project.

Mixologic’s picture

Aha. No wonder why I cant find it:

Note that this functionality is not available to users without the permission to create full projects.

https://drupal.org/node/1449736
Maybe that policy needs to be reconsidered...

If a user who doesn't have full project permission submits a patch to a project, they ought to be able to get feedback for that patch.

jthorson’s picture

Issue summary: View changes
jthorson’s picture

Issue summary: View changes
drumm’s picture

Project: DrupalCI: Drupal.org Integration (Modernizing Testbot Initiative) » Project issue file test
Version: » 7.x-2.x-dev
Assigned: Unassigned » drumm
drumm’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev
drumm’s picture

Assigned: drumm » Unassigned
drumm’s picture

drumm’s picture

Title: Modernizing Testbot: Drupal.org User Interface » DrupalCI retest & special test UI
drumm’s picture

Assigned: Unassigned » drumm

  • drumm committed 14d3125 on 7.x-3.x
    Issue #2238007: Add add tests form
    
  • drumm committed 54519b8 on 7.x-3.x
    Issue #2238007: Fix menu use
    
  • drumm committed 993ca2b on 7.x-3.x
    Issue #2238007: Add link to add tests
    
drumm’s picture

Here is the progress so far. For the files tables in issues:
Screenshot

And where "Add test" links to:
Screenshot

  • drumm committed 2cc15ea on 7.x-3.x
    Issue #2238007: Stash file for future form processing
    
  • drumm committed 58a8fe0 on 7.x-3.x
    Issue #2238007: Validation and submit handling for add tests
    
  • drumm committed b14656e on 7.x-3.x
    Issue #2238007: More-specific checking for queued tests
    
drumm’s picture

Issue summary: View changes
Status: Active » Needs review

Adding screenshots to the issue summary.

  • drumm committed 7995203 on 7.x-3.x
    Issue #2238007: DrupalCI retest...

  • drumm committed 72665da on 7.x-3.x, retests
    Issue #2238007: DrupalCI retest...

  • drumm committed 2da9c4a on 7.x-3.x
    Issue #2238007: DrupalCI retest & special test UI, add project UI
    

  • drumm committed 3ec548c on 7.x-3.x
    Issue #2238007: DrupalCI retest & special test UI, comment
    
  • drumm committed 4a115a8 on 7.x-3.x
    Issue #2238007: DrupalCI retest & special test UI, wording change
    

  • drumm committed 17b8746 on
    Issue #2238007: DrupalCI retest & special test UI, comments
    
  • drumm committed 95dbe9a on
    Issue #2238007: DrupalCI retest...
drumm’s picture

Status: Needs review » Fixed

I completed the branch retesting. I'm going to be bold and call this fixed. We can open up followup issues for anything specific we find.

  • drumm committed d5e9978 on 7.x-3.x
    Issue #2238007: DrupalCI retest...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.