Attached patch moves necessary Javascript files to a local folder for performance reasons

CommentFileSizeAuthor
#3 ssl_safari_error.jpg84.14 KBmoehac
#3 ssl_chrome_error.jpg68.99 KBmoehac
#1 translate_this.patch83.76 KBzahor
translate_this.patch48.8 KBzahor

Comments

zahor’s picture

zahor commented
StatusFileSize
new translate_this.patch83.76 KB
BarisW’s picture

BarisW commented
Status: Closed (fixed) » Postponed (maintainer needs more info)

Why would that be a good thing? Not sure if it's allow in their TOS: http://translateth.is/tos

PS: never close an issue when creating one. If you supply a patch, leave it to "needs review".

moehac’s picture

moehac commented
Issue tags: +#nodejs
StatusFileSize
new ssl_chrome_error.jpg68.99 KB
new ssl_safari_error.jpg84.14 KB

I like the idea of a CDN delivering translate-this.js, but current issue is that '://x.translateth.is/translate-this.js' does not accept a SSL connection. I get following errors in Safari and Chrome (attached) which break my site.

I had to disable this module all together since it uses an old version of socket.io (0.9.x), which conflicts with #nodejs 0.10.x version.

BarisW’s picture

BarisW commented

I've sent the maintainer of the TranslateTh.is plugin an e-mail to check for the SSL status. This worked in the past, so the SSL certificate must have been changed.