#2218655: Core expects $theme.settings default config file to exist moves the schema from system.schema.yml to core.data_types.schema.yml, but doesn't change the contents. The contents, however, has the label "Shortcut icon settings" 3 times: for favicon, features, and logo. That's the correct label for the first one, but not for the other two.

CommentFileSizeAuthor
#10 drupal-theme_setting_labels_dup-2236089-10.patch754 bytescs_shadow
#9 drupal-theme_setting_labels_dup-2236089-9.patch754 bytescs_shadow
#7 drupal-theme_setting_labels_dup-2236089-7.patch759 bytescs_shadow
#5 drupal-theme_setting_labels_dup-2236089-4.patch759 bytescs_shadow
#2 theme.settings.02.patch12.32 KBsriharsha.uppuluri
#2 interdiff.txt694 bytessriharsha.uppuluri

Comments

effulgentsia’s picture

effulgentsia commented
Issue tags: +Novice
sriharsha.uppuluri’s picture

sriharsha.uppuluri commented
Assigned: Unassigned » sriharsha.uppuluri
Status: Active » Needs review
StatusFileSize
new interdiff.txt694 bytes
new theme.settings.02.patch12.32 KB

I have renamed the label of
features - Features icon settings,
logo - Logo settings

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

The parent issue has landed, so we just need the config schema label adjustments here now :-)

sriharsha.uppuluri’s picture

sriharsha.uppuluri commented
Assigned: sriharsha.uppuluri » Unassigned
cs_shadow’s picture

cs_shadow commented
Status: Needs work » Needs review
StatusFileSize
new drupal-theme_setting_labels_dup-2236089-4.patch759 bytes

Attaching patch that just changes config labels.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented 
+++ b/core/config/schema/core.data_types.schema.yml
@@ -122,7 +122,7 @@ theme_settings:
-      label: 'Shortcut icon settings'
+      label: 'Features icon settings'

Just "Feature settings" (no icon involved)

Or "Optional features" ? (AFAIK, all of them are boolean on/off checkbox toggles only)

cs_shadow’s picture

cs_shadow commented
StatusFileSize
new drupal-theme_setting_labels_dup-2236089-7.patch759 bytes

Attaching patch where its renamed to "Optional Features".

Status: Needs review » Needs work

The last submitted patch, 7: drupal-theme_setting_labels_dup-2236089-7.patch, failed testing.

cs_shadow’s picture

cs_shadow commented
Status: Needs work » Needs review
StatusFileSize
new drupal-theme_setting_labels_dup-2236089-9.patch754 bytes

Attaching the correct path mentioned in #8.

cs_shadow’s picture

cs_shadow commented
StatusFileSize
new drupal-theme_setting_labels_dup-2236089-10.patch754 bytes

Changed to follow sentence-casing.

The last submitted patch, 9: drupal-theme_setting_labels_dup-2236089-9.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks! :-)

  • Commit 2aacece on 8.x by catch: 
    Issue #2236089 by cs_shadow, sriharsha.uppuluri: theme_settings schema...
star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Just missing this:

Committed/pushed to 8.x, thanks!

:)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.