Broken/missing handler (Module: node) …

I am not sure if "$display_options['fields']['title']['link_to_node_field_revision'] = 1;" is needed but, the remaining patch seems to resolve the issue. The modal for selecting fields seems broken, but I am not sure if thats related to this.

1: 2229167.patch queued for re-testing.

Yhea, kinda figured it wasn't needed. I am not sure how to test this :) I thought we had tests for it already but I guess that only tests whether we actually get results from this.

1. +++ b/core/modules/node/lib/Drupal/node/Plugin/views/wizard/NodeRevision.php
   @@ -95,20 +95,20 @@ protected function defaultDisplayOptions() {
   +    $display_options['fields']['changed']['alter']['alter_text'] = 0;
   +    $display_options['fields']['changed']['alter']['make_link'] = 0;
   +    $display_options['fields']['changed']['alter']['absolute'] = 0;
   +    $display_options['fields']['changed']['alter']['trim'] = 0;
   +    $display_options['fields']['changed']['alter']['word_boundary'] = 0;
   +    $display_options['fields']['changed']['alter']['ellipsis'] = 0;
   +    $display_options['fields']['changed']['alter']['strip_tags'] = 0;
   +    $display_options['fields']['changed']['alter']['html'] = 0;
   +    $display_options['fields']['changed']['hide_empty'] = 0;
   +    $display_options['fields']['changed']['empty_zero'] = 0;
   

   While we are changing these, shall we make them real booleans?

2. +++ b/core/modules/node/lib/Drupal/node/Tests/Views/NodeRevisionWizardTest.php
   @@ -0,0 +1,77 @@
   +    $node = $node->createDuplicate();
   +    $node->isNewRevision();
   +    $node->created->value = REQUEST_TIME + 20;
   +    $node->save();
   

   Didn't know you had to do that, I would have just called isNewRevision() and saved again. Does it need to be a new object? Sorry, haven't looked at the entity system changes for quite a while! More of a question than anything.

Also, how was anything working before without the join to node_revision from node_field_revision??

+++ b/core/modules/node/lib/Drupal/node/Tests/Views/NodeRevisionWizardTest.php
@@ -0,0 +1,77 @@
+    $node->isNewRevision();
...
+    $node->isNewRevision();

Was this supposed to be setNewRevision()? isNewRevision just returns a boolean, it doesn't *do* anything.

Otherwise I think this is fine.

Reviewing the patch :)

Should the tests have passed anyway when the nodes were not being set as new revisions as per Tim's comment above?

By default, when we are creating a new node, the new revision id is added to the node_revision table. So, should not fail and afaik we don't need to force a new revision in this test. Removing this method from the test...

Sorry, do you have an interdiff for that? :)

The last hunk is out of scope, but it's not too bad.
Nice test, thanks!

Committed/pushed to 8.x, thanks!