The function comment_user_cancel uses COMMENT_NOT_PUBLISHED which was removed in Drupal 8.
We need to change that to CommentInterface::NOT_PUBLISHED.

CommentFileSizeAuthor
#9 2227465-9-comment-unpublished-constant--test.patch2.5 KBgremy
#9 2227465-9-comment-unpublished-constant.patch3.12 KBgremy
#3 2227465-3-comment-unpublished-constant.patch632 bytesbogdan.racz

Comments

gremy’s picture

gremy commented
Title: comment_user_cancel uses COMMENT_NOT_PUBLISHED » comment_user_cancel() uses COMMENT_NOT_PUBLISHED
bogdan.racz’s picture

bogdan.racz commented
Assigned: Unassigned » bogdan.racz
bogdan.racz’s picture

bogdan.racz commented
StatusFileSize
new 2227465-3-comment-unpublished-constant.patch632 bytes

I have updated the constant with the proper one - CommentInterface::NOT_PUBLISHED.

bogdan.racz’s picture

bogdan.racz commented
Status: Active » Needs review
gremy’s picture

gremy commented
Status: Needs review » Needs work
Issue tags: +Needs tests

I looked the patch and it looks OK to me.

Also I searched the entire Drupal core and besides this place there is no definition COMMENT_NOT_PUBLISHED, and this is the only place where it was called.

I think that we need some tests to be written for this issue.

gremy’s picture

gremy commented
Issue summary: View changes
swentel’s picture

swentel commented
Priority: Critical » Major

Ok, this is not extremely critical, but still major though.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Good find thanks

gremy’s picture

gremy commented
StatusFileSize
new 2227465-9-comment-unpublished-constant.patch3.12 KB
new 2227465-9-comment-unpublished-constant--test.patch2.5 KB

Updated the UserCancelTest->testUserBlockUnpublish() test.
Created patch with the test only, so that if it fails we know it works.
Rerolled rbmboogie's patch with the test included, so that if this patch passes the tests we can confirm that the patch works.

gremy’s picture

gremy commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: 2227465-9-comment-unpublished-constant--test.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Reviewed & tested by the community

Awesome work. For next time, uploading the failing test first will ensure bit doesn't change the status.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 669b898 on 8.x by catch: 
    Issue #2227465 by gremy, rbmboogie: comment_user_cancel() uses...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.