Problem/Motivation

We don't support ie8 anymore in Drupal, the .views-row-odd, .views-row-even, .views-row-first, .views-row-last classes is not needed more it can be done with css & n-th selectors

Proposed resolution

.views-row-odd, .views-row-even, .views-row-first, .views-row-last from views-view-unformatted.html.twig

Remaining tasks

User interface changes

views format settings :
- remove options: Add views row classes
- remove options: Add striping (odd/even), first/last row classes

API changes

CommentFileSizeAuthor
#16 vdc-2226933-16.patch13.25 KBcs_shadow
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,388 pass(es). View
#13 vdc-2226933-13.patch12.96 KBtim.plunkett
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,616 pass(es). View
#2 drupal-2226933-remove-classes-from-views-2.patch3.04 KBmandar.harkare
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,787 pass(es). View
views-remove-odd-even-count.diff2.79 KBmortendk
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch views-remove-odd-even-count.diff. Unable to apply patch. See the log in the details link for more information. View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

mortendk’s picture

Issue summary: View changes
mandar.harkare’s picture

Status: Active » Needs review
FileSize
3.04 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 66,787 pass(es). View
Manuel Garcia’s picture

Issue tags: +Views dreammarkup, +dreammarkup
Manuel Garcia’s picture

Issue tags: -Views dreammarkup +VDC
MarkusDBX’s picture

Assigned: Unassigned » MarkusDBX

Working on patch review.

MarkusDBX’s picture

Status: Needs review » Reviewed & tested by the community

Confirmed that this patch still works.

The last submitted patch, views-remove-odd-even-count.diff, failed testing.

MarkusDBX’s picture

Assigned: MarkusDBX » Unassigned
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

  • Commit 7982985 on 8.x by catch:
    Issue #2226933 by mandar.harkare, mortendk: Remove odd, even, first...
mortendk’s picture

#win!

tim.plunkett’s picture

Status: Fixed » Needs work

No one from VDC reviewed this.
You left all of the UI options behind, now there are parts of views config and views UI that have no effect on a view.

That doesn't really make sense.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
12.96 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,616 pass(es). View

I think when removing functionality from the Views UI, two things should happen:

  1. The UI should actually be updated
  2. One of the Views UI maintainers should be consulted before commit
mortendk’s picture

yup looks like somebody was quick on the tricker *assings blame*

joelpittet’s picture

Status: Needs review » Needs work

Reviewing the patch in #13, there is one more $count = 0; that isn't being used in template_preprocess_views_view_table()
on line #677.

Check all the other variables that were removed to see if any stranglers and other than that this looks good to me.
With that fix I think it's back to RTBC.

@tim.plunkett thanks for spotting this oversight and providing the patch.

cs_shadow’s picture

Status: Needs work » Needs review
FileSize
13.25 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 70,388 pass(es). View

Removed the stray $count mentioned in #15.

Couldn't find any other such variables.

joelpittet’s picture

Status: Needs review » Reviewed & tested by the community

@cs_shadow thanks, that's the one, back to RTBC.

An interdiff would be nice next time, saves me from comparing the diff between the the last two patches @see https://drupal.org/documentation/git/interdiff.

  • Commit 69fb5dc on 8.x by catch:
    Issue #2226933 by cs_shadow, tim.plunkett, mandar.harkare, mortendk:...
catch’s picture

Status: Reviewed & tested by the community » Fixed

@Tim this had been in the Views component since March 27th, tagged VDC for over a month before commit, and was RTBC (still tagged VDC) for four days before commit. I don't see how else to communicate with Views maintainers except for individually pinging you in irc prior to each commit?

If we'd had tests for this part of the UI checking the resulting markup, they'd have failed. Since we didn't have tests, nothing failed. Given we're removing the entire thing, we'd be removing those tests as part of this patch had they ever existed. Seems OK in the scheme of regressions elsewhere.

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.