Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
We don't support ie8 anymore in Drupal, the .views-row-odd, .views-row-even, .views-row-first, .views-row-last classes is not needed more it can be done with css & n-th selectors
Proposed resolution
.views-row-odd, .views-row-even, .views-row-first, .views-row-last from views-view-unformatted.html.twig
Remaining tasks
User interface changes
views format settings :
- remove options: Add views row classes
- remove options: Add striping (odd/even), first/last row classes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | vdc-2226933-16.patch | 13.25 KB | cs_shadow |
| #13 | vdc-2226933-13.patch | 12.96 KB | tim.plunkett |
| #2 | drupal-2226933-remove-classes-from-views-2.patch | 3.04 KB | mandar.harkare |
| views-remove-odd-even-count.diff | 2.79 KB | mortendk | |
Comments
Comment #1
mortendk CreditAttribution: mortendk commentedComment #2
mandar.harkare CreditAttribution: mandar.harkare commentedComment #3
Manuel Garcia CreditAttribution: Manuel Garcia commentedComment #4
Manuel Garcia CreditAttribution: Manuel Garcia commentedComment #5
MarkusDBX CreditAttribution: MarkusDBX commentedWorking on patch review.
Comment #6
MarkusDBX CreditAttribution: MarkusDBX commentedConfirmed that this patch still works.
Comment #8
MarkusDBX CreditAttribution: MarkusDBX commentedComment #9
catchCommitted/pushed to 8.x, thanks!
Comment #11
mortendk CreditAttribution: mortendk commented#win!
Comment #12
tim.plunkettNo one from VDC reviewed this.
You left all of the UI options behind, now there are parts of views config and views UI that have no effect on a view.
That doesn't really make sense.
Comment #13
tim.plunkettI think when removing functionality from the Views UI, two things should happen:
Comment #14
mortendk CreditAttribution: mortendk commentedyup looks like somebody was quick on the tricker *assings blame*
Comment #15
joelpittetReviewing the patch in #13, there is one more
$count = 0;that isn't being used in template_preprocess_views_view_table()on line #677.
Check all the other variables that were removed to see if any stranglers and other than that this looks good to me.
With that fix I think it's back to RTBC.
@tim.plunkett thanks for spotting this oversight and providing the patch.
Comment #16
cs_shadow CreditAttribution: cs_shadow commentedRemoved the stray $count mentioned in #15.
Couldn't find any other such variables.
Comment #17
joelpittet@cs_shadow thanks, that's the one, back to RTBC.
An interdiff would be nice next time, saves me from comparing the diff between the the last two patches @see https://drupal.org/documentation/git/interdiff.
Comment #19
catch@Tim this had been in the Views component since March 27th, tagged VDC for over a month before commit, and was RTBC (still tagged VDC) for four days before commit. I don't see how else to communicate with Views maintainers except for individually pinging you in irc prior to each commit?
If we'd had tests for this part of the UI checking the resulting markup, they'd have failed. Since we didn't have tests, nothing failed. Given we're removing the entire thing, we'd be removing those tests as part of this patch had they ever existed. Seems OK in the scheme of regressions elsewhere.
Committed/pushed to 8.x, thanks!