Remove remaining uses of deprecated language functions (mostly in object oriented code)

Fixed constructors to get LanguageListTest to pass.... these errors seem common to many other failings

I have worked on this issue and am quite happy to work on it again... so just let me know if I can help out...

But for the moment putting my reviewers hat on and thinking.

There are several examples of procedural function calls, within classes .. the trend is to move to direct dependency injection unless in an .module of .install file etc

Here is example in the class \Drupal\Core\Session\UserSession

function getPreferredLangcode($default = NULL) {
    * {@inheritdoc}
    */
   function getPreferredAdminLangcode($default = NULL) {
-    $language_list = language_list();
+    $language_list = \Drupal::languageManager()->getLanguages();
     if (!empty($this->preferred_admin_langcode) && isset($language_list[$this->preferred_admin_langcode])) {

Where the languageManager service could be injected.

Also the config_translation.access.form service definition arguments could be updated to directly inject the languageManager into the class \Drupal\config_translation\Access\ConfigTranslationFormAccess.

I have taken a slow, careful scan of this patch, it looks good to me

Nothing out of scope, all changes appropriate, a good cleanup.

I have worked on this so won't move to RTBC but +1 from me.

+++ b/core/lib/Drupal/Core/Session/UserSession.php
@@ -183,12 +183,12 @@ public function isAnonymous() {
+    $language_list = \Drupal::languageManager()->getLanguages();
...
+      return $default ? $default : \Drupal::languageManager()->getDefaultLanguage()->id;

@@ -196,12 +196,12 @@ function getPreferredLangcode($default = NULL) {
+    $language_list = \Drupal::languageManager()->getLanguages();
...
+      return $default ? $default : \Drupal::languageManager()->getDefaultLanguage()->id;

+++ b/core/modules/content_translation/src/Access/ContentTranslationManageAccessCheck.php
@@ -65,12 +65,12 @@ public function access(Route $route, Request $request, AccountInterface $account
+      $languages = \Drupal::languageManager()->getLanguages();
...
+          $source = \Drupal::languageManager()->getLanguage($source) ?: $entity->language();
+          $target = \Drupal::languageManager()->getLanguage($target) ?: \Drupal::languageManager()->getCurrentLanguage(LanguageInterface::TYPE_CONTENT);

@@ -80,7 +80,7 @@ public function access(Route $route, Request $request, AccountInterface $account
+          $language = \Drupal::languageManager()->getLanguage($language) ?: \Drupal::languageManager()->getCurrentLanguage(LanguageInterface::TYPE_CONTENT);

+++ b/core/modules/content_translation/src/ContentTranslationHandler.php
@@ -99,7 +99,7 @@ public function entityFormAlter(array &$form, array &$form_state, EntityInterfac
+    $languages = \Drupal::languageManager()->getLanguages();

@@ -132,7 +132,7 @@ public function entityFormAlter(array &$form, array &$form_state, EntityInterfac
+      foreach (\Drupal::languageManager()->getLanguages(LanguageInterface::STATE_CONFIGURABLE) as $language) {

@@ -145,7 +145,7 @@ public function entityFormAlter(array &$form, array &$form_state, EntityInterfac
+      foreach (\Drupal::languageManager()->getLanguages(LanguageInterface::STATE_CONFIGURABLE) as $language) {

+++ b/core/modules/content_translation/src/Controller/ContentTranslationController.php
@@ -29,8 +29,8 @@ public function overview(Request $request) {
+    $source = \Drupal::languageManager()->getLanguage($source);
+    $target = \Drupal::languageManager()->getLanguage($target);

+++ b/core/modules/user/src/Entity/User.php
@@ -367,13 +367,13 @@ public function getTimeZone() {
+    $language_list = \Drupal::languageManager()->getLanguages();
...
+      return $default ? $default : \Drupal::languageManager()->getDefaultLanguage()->id;

@@ -381,13 +381,13 @@ function getPreferredLangcode($default = NULL) {
+    $language_list = \Drupal::languageManager()->getLanguages();
...
+      return $default ? $default : \Drupal::languageManager()->getDefaultLanguage()->id;

lets store the language manager to a variable to avoid some extra \Drupal:: calls

Needs work per #35.

Reroll before doing #35.

Lots of simple touches needed, but the sheer number of them, makes me think I will have to come back to this.

While merging with recent changes the order of the final parameters to ContentEntityDatabaseStorage::_construct(), cache and languageManager
has have been reversed. So all changes are of the form

-      ->setConstructorArgs(array($this->entityType, $this->connection, $this->entityManager, $this->languageManager, $this->cache))
+      ->setConstructorArgs(array($this->entityType, $this->connection, $this->entityManager, $this->cache, $this->languageManager))

This will not fix all errors. Just ContentEntityDatabaseStorageTest.php

Rats, #40 waited 11.5 hours in the queue.... in the mean time #2285083: Rename contact category to contact form was committed and caused a reroll.

in the end no drama, a single line fix to ConfigTranslationUiTest,

Fixed a couple of side issues, just posting what I have so far..I have not fixed the failing error yet!

a) This issue introduces a new test which contains the flaw that #2322889: Various setUp() and tearDown() methods are not protected fixed.

b) The name of the content entity type is now menu_link_content :-

-    $menu_items = \Drupal::entityManager()->getStorage('menu_link')->loadByProperties(array('route_name' => 'menu_test.context'));
+    $menu_items = \Drupal::entityManager()->getStorage('menu_link_content')->loadByProperties(array('route_name' => 'menu_test.context'));

This seems to be the correct thing to do, but now as I run this test through the debugger by the time the program reaches this line, the contents of the relevant table in the database are empty. So my problem has become why is the db not being populated correctly?

Patch no longer applied .. reroll.

As far as I can see all changes related to #1987882: Convert content_translation routes to a new style controller - anyway in all instances changes in head taken over changes in this patch - that was appropriate as only modern dependency injected function a calls were made in that patch.

So this patch get a little smaller.

I am finding stepping through MenuRouterRebuildTest a bit of a pain it takes several minutes to get to the point of interest.

I want to speed up the whole process before fixing the bug by moving from extending WebTestBase to KernelTestBase.

To pull some quotes form #2287223: Use KernelTestBase for config schema tests where possible

we can now turn some WebTestBase classes into KernelTestBase

None of these tests make web requests, they just deal with data and APIs.

extending KernelTestBase still makes MenuRouteRebuildTests an integration test, BUT I see a large speedup in test time.

The time taken to run MenuRouteRebuildTests from the command line drops from 28 seconds to 4 secs which should translate to an even bigger speedup when I start stepping through the debugger.

The question in the back of my mind is that I may have changed the setup of the test in some subtle way.
If reviewers could comment I would be grateful...

Lots has changed in the language module recently ... which is a good thing.

So this is a reroll... some things have become simplified.

Ah rats, In the last comment lots of tests pasts... but I did not run a lint check of all files modified :)

now I have and there should be more more errors of this type

Reverted a line in DisplayPluginBase.php, which is now an unnecessary change.

Seems to be responsible for most of the exceptions.

Hmm back to the same stage as #50.

Not sure how to proceed, I think it maybe something trivial.

#2328293: Remove usage of language_list() is now RTBC. Let's get that in :)

I mean and THEN get back here to work on the rest.

New attempt.

Function language and language_list are already removed so language_load and language_default are the only remaining.

Fixed the failing tests.

There are still 4 failing tests in LanguageUILanguageNegotiationTest.

I will investigate this further tomorrow.

I think I was half asleep last night.

The key to review I think with the patch is that all the places you took the language manager from \Drupal, none of them had a language manager injected locally?

Made changes as suggested by ianthomas_uk in #2225427-74: Remove remaining uses of deprecated language functions (mostly in object oriented code).

Found one more call to \Drupal::languageManager() where we could use the injected service, instead. (Damn... the patch-76 should have been removed.)

@DevelCuy: the issue is still a perfect one to review on sprint weekend. :)

Removed SprintWeekend2015Queue by mistake.

This issue is a prioritized change (deprecated functions) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed c34c3df and pushed to 8.0.x. Thanks!

diff --git a/core/modules/config/src/Tests/ConfigLanguageOverrideTest.php b/core/modules/config/src/Tests/ConfigLanguageOverrideTest.php
index 9dac7f5..4970681 100644
--- a/core/modules/config/src/Tests/ConfigLanguageOverrideTest.php
+++ b/core/modules/config/src/Tests/ConfigLanguageOverrideTest.php
@@ -94,7 +94,7 @@ function testConfigLanguageOverride() {
     $this->assertIdentical($config->get('value'), array('key' => 'override'));
 
     // Ensure renaming the config will rename the override.
-    \Drupal::languageManager()->setConfigOverrideLanguage(language_load('en'));
+    \Drupal::languageManager()->setConfigOverrideLanguage(\Drupal::languageManager()->getLanguage('en'));
     \Drupal::configFactory()->rename('config_test.foo', 'config_test.bar');
     $config = \Drupal::config('config_test.bar');
     $this->assertEqual($config->get('value'), array('key' => 'original'));

Fixed on commit.

Fantastic, thanks! Settings good examples++