Remove all calls to deprecated function language()

Hope it will pass.

Thank you @Mac_Weber for reviewing. here is the new patch and indiff txt file.

This patch doesn't apply anymore, so it needs to be re-rolledc.

Reroll attached

let's test.

Reviewed my reroll patch #10 - d'oh - and submitted a new reroll from patch #8.

Submitted for testing

Submitted for testing

@bdgreen, all Drupal:: references should be prefixed with a backslash. this has been standardized in core: #2053489: Standardize on \Drupal throughout core.

otherwise, good job.

Thanks @herom. Corrections made.

18: drupal8.language.module-remove_deprecated_function_language-2070369-18.patch queued for re-testing.

@bdgreen this needs another reroll now.

Rerolled ;)

I guess you didn't reroll #18, ha? just repeat what you did at #14 and #18 on top of #23.

Yep. Reverted to #14, and since found two further corrections- but now waiting for test results before submitting xD

23: drupal8.language.module-remove_deprecated_function_language-2070369-23.patch queued for re-testing.

I am working on re-rolling #29 patch but I found that
LanguageManager::getLanguage was changed in #1862202: Objectify the language system and now it requires $langcode to be specified.
So, LanguageManager::getCurrentLanguage should be used instead. I.e.

should be

  $language = \Drupal::languageManager()->getCurrentLanguage();

instead of

  $language = \Drupal::languageManager()->getLanguage();

Here is re-rolled and corrected patch.
It removes all calls of the language() and function language() itself.
Actually, all calls of the language() were replaced by \Drupal::languageManager()->getCurrentLanguage() according to https://drupal.org/node/2174591.

Seems I missed one place to replace language()

Updated the summary following API changes.

+++ b/core/lib/Drupal/Core/Routing/UrlGeneratorInterface.php
@@ -55,7 +55,7 @@
+   *     obtained from \Drupal::languageManager()->getCurrentLanguage(Language::TYPE_URL).

Will it? I had a quick look at the implementation of this and I think it's already using an injected object. I don't think this is something we can specify at the interface level so we should just remove the sentence. Similar comments appear elsewhere in the interface and in Drupal.php (the line is also over 80 characters BTW).

+++ b/core/includes/entity.inc
@@ -120,7 +120,7 @@ function entity_invoke_bundle_hook($hook, $entity_type, $bundle, $bundle_new = N
-    $langcode = language(Language::TYPE_INTERFACE)->id;
+    $langcode = \Drupal::languageManager()->getCurrentLanguage()->id;

We've lost Language::TYPE_INTERFACE. I'm not sure if this was a deliberate choice because TYPE_INTERFACE is the default, but surely it's better to be explict. There are lots of examples of this.

+++ b/core/modules/ckeditor/ckeditor.admin.inc
@@ -20,7 +20,7 @@
+  $language_interface = \Drupal::languageManager()->getCurrentLanguage(Language::TYPE_CONTENT);
...
-  $language_interface = language(Language::TYPE_INTERFACE);

Here we're switching from TYPE_INTERFACE to TYPE_CONTENT. If that's intentional it's out of scope (and the variable name should have been changed too.)

First part: I'd just convert that into an actual sentence, something like "Defaults to the current language for the language type Language::TYPE_URL"?

Second part, +1 to removing the default, existing examples often specify it because there used to be no default value. The idea is that if you don't know which one you need, it's very likely the default.

ckeditor: Yep, that looks wrong, probably a wrong copy & paste?

rerolled, and fixed points in #36.

+++ b/core/includes/bootstrap.inc
@@ -2072,21 +2072,6 @@ function drupal_language_initialize() {
-function language($type) {
-  return \Drupal::languageManager()->getCurrentLanguage($type);
-}

Currently we're keeping the functions themselves in, which reduces the chance of breaking HEAD and makes the eventual removal patch easier to roll back.

Other than that, this patch looks ready.

patch without removing language() function.

All my concerns have been addressed

remove-language-2070369-40.patch no longer applies.

error: patch failed: core/modules/locale/locale.module:693
error: core/modules/locale/locale.module: patch does not apply

Created reroll.

Patch attached.

replacing 1 new language() call.

reroll looks good

Committed and pushed to 8.x. Thanks!

Looks like the change notice at https://drupal.org/node/2174591 covers this change and then some, so we appear to be good there.