Tracker page doesn't order results properly

https://drupal.org/contributor-tasks/write-tests is instructions for adding automatic tests.

can we even test this?
I'm not sure about usual way for drupal 7.x

---
this also needs a review.
https://drupal.org/contributor-tasks/review is instructions for reviewing.

---

please make a comment if someone starts to do either of those tasks.

pwolanin reviewed this patch today and it needs some more work, updating status accordingly.

I wanted to test the patches manually but can't reproduce the issue. Please provide me exact steps how to reproduce it.

tracker_page() has changed a lot in the git repo. I couldn't apply it locally.

I came from #2130537: user/%/track not sorting correctly

I would ask you to consider this as Major
as it is affecting all users of d.o.

noone at this time can track their d.o. posts sorted by date

I know there is the issue tracker on the dashboard and clicking on more from there
but that solves only HALF of the problem

what about regular posts ? (not issues)

for more details look at
this postponed issue > #2130537: user/%/track not sorting correctly

and a long time workaround since the previous issue which now is not working > #2133945: "Your posts" dashboard block sorts items on the last comment
and was decided as MAJOR for the very reason I am posting about

What I see in _tracker_add() in 8.x is:

  // Update the node-level data.
  db_merge('tracker_node')
    ->key('nid', $nid)
    ->fields(array(
      'changed' => $changed,
      'published' => $node->status,
    ))
    ->execute();

  // Create or update the user-level data.
  db_merge('tracker_user')
    ->keys(array(
      'nid' => $nid,
      'uid' => $uid,
    ))
    ->fields(array(
      'changed' => $changed,
      'published' => $node->status,
    ))
    ->execute();

The second db_merge() looks like it should update all rows matching the nid, not just the one user. The node is changed at the same time for everyone, and especially published or not the same for everyone. tracker_cron() looks like it has the correct logic.

Maybe it is as simple as this. I'm guessing more tests would still be good.

Attached is a more-careful patch.

This should fix the misuse of db_update.

The way to test for this would be checking tracker page as another user sees it. The timestamps are updating for the commenter's tracker, but not everyone else's.

(Assigning to myself so I stop looking at my own patch.)

23: 2224917.patch queued for re-testing.

Working on this at the contribution sprint, so assigning to myself.

Added a basic issue summary, and will continue to update it as I get to grips with this issue.

Added some steps to reproduce to the issue summary, I'm going to test the patchy patch now.

Patch in #2224917: Tracker page doesn't order results properly fixes the issue for me.

I guess that for me the comment that has been changed should maybe be split so that it's directly above the db_update too, might make more sense when reading.

Also, setting back to needs work, as this thing needs a test, right?

Added the novice tasks stuff to the issue summary.

Spoken to tvn, and I'm going to write some tests.

Wow that took a lot longer than I was expecting, and sadly I had to rely on the ordering in the HTML using a regex.

Here's a patch that includes just the test.

And here's a patch that includes the fix as well.

My work here is done, un-assigning myself.

Looks good to me.

Committed d084d2d and pushed to 8.x. Thanks!

Thanks very much Alex.

On the patch...

Here's a re-roll for Drupal 7.

Looks good.

Let's keep "affects Drupal.org" since it hasn't made it into 7.x yet. Deploying later today.

Now deployed to Drupal.org. Since there isn't a DB update, the improved ordering will only be visible for recently-updated nodes. I'm okay with not having a DB update; updating the large, busy table would probably need a downtime scheduled, or careful batching.

Sorry for all the tag noise.

37: drupal-2224917-tracker-incorrect-ordered.patch queued for re-testing.

Many thanks to those who worked on this.

45: drupal-2224917-tracker-page.patch queued for re-testing.

The fail in #54 looks like a testbot error.

Not exactly a testbot error, just the 8.x patch being re-queued against 7.x. #45 is still good to go.

Sorry I meant the fail in #52 was a random testbot fail, I re-queued the patch, and all the tests passed fine.

Committed to 7.x - thanks!