Add hook_deploy_auto_plan_entity_save_alter(&$plan_name, &$entity_type, &$entity) where modules can use $entity->skip_auto_deploy to exclude entity from auto deploy.
Use case: entities, that are imported by Feeds module has to be excluded.
Solution: exclude this entities from deployment plan by setting $entity->skip_auto_deploy variable to TRUE.

CommentFileSizeAuthor
#6 add_hook_deploy_auto_plan_entity_save_alter-2224901-6-7.x.patch1.83 KBartematem
#3 add_hook_deploy_auto_plan_entity_save_alter-2224901-3-7.x.patch1.83 KBartematem
#1 add_hook_deploy_auto_plan_entity_save_alter-2224901-1-7.x.patch1.86 KBartematem

Comments

artematem’s picture

artematem commented
StatusFileSize
new add_hook_deploy_auto_plan_entity_save_alter-2224901-1-7.x.patch1.86 KB

Added patch file.

Status: Needs review » Needs work

The last submitted patch, 1: add_hook_deploy_auto_plan_entity_save_alter-2224901-1-7.x.patch, failed testing.

artematem’s picture

artematem commented
StatusFileSize
new add_hook_deploy_auto_plan_entity_save_alter-2224901-3-7.x.patch1.83 KB

Updated patch

artematem’s picture

artematem commented
Status: Needs work » Needs review

Status > Needs review

Status: Needs review » Needs work

The last submitted patch, 3: add_hook_deploy_auto_plan_entity_save_alter-2224901-3-7.x.patch, failed testing.

artematem’s picture

artematem commented
Status: Needs work » Needs review
StatusFileSize
new add_hook_deploy_auto_plan_entity_save_alter-2224901-6-7.x.patch1.83 KB

Fixed patch

Status: Needs review » Needs work

The last submitted patch, 6: add_hook_deploy_auto_plan_entity_save_alter-2224901-6-7.x.patch, failed testing.

dasha_v’s picture

dasha_v commented

Hi skwashd, dixon_ ,

Could you please help up with this patch?
It is failing with PHP Fatal error in deploy.test: "Call to undefined function deploy_endpoint_load().".
It looks like the error is not related to the patch code, but may be with latest dev branch code. Do you know how can this be fixed?

Thank you in advance,
Dasha and Artem

skwashd’s picture

skwashd commented

The function is defined at line 244 of deploy.module. I haven't tried testing locally to see what is going on.

I have concerns about accepting this patch. The whole idea of this module is that it adds every entity that is created/updated to the specified plan. I don't understand when you would want to create entities in lower environments that shouldn't propagate to production. If you don't want to use the behaviour of this module, maybe deploy_plan_ui or rules is more appropriate for your use case.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented

I agree with @skwashd. It sounds like you should make use of the proper Rules integration, rather than nesting more functionality into deploy_auto_plan that was meant to be really simple and straight forward.

skwashd’s picture

skwashd commented
Status: Needs work » Closed (won't fix)

Based on @dixon_'s comment, I'm closing this WONTFIX.