xmlsitemap_menu.module uses hook_entity_info_alter(), and so doesn't get a token type set by token module

So what solution do you recommend?

As XMLSitemap does not depend upon the Token module, I don't think it's strictly a bug in XMLSitemap.

How and where to edit this?

Would it also fix it if we changed xml sitemap to run the alter before token then?

@dandaman's solution worked for me. I changed the module weight to -1, and it passed all tests.

Attached is a patch that implements it.

PLEASE REVIEW because there might be other consequences of changing module weight.

Having the errors too. Mainly triggering this error:

Notice: Undefined index: token type in flag_token_info() (line 88 of /srv/bindings/9fe9a2846c534faab85e3b36c93bb52c/code/sites/all/modules/flag/flag.tokens.inc).

Patch in #7 worked for me.

Hello,

I attach a patch that add a 'token type' key in the hook_entity_info_alter.

I don't test if it is the proper solution but it solved the warning.

I don't think the patch in #7 is a good solution because it only hides the problem. And the hook_update_N in this patch is for a D6, no ?

Thanks for the review.

The problem is that we're registering an entity type for a table provided by core. What happens when another contrib module wants to declare menu links as entities and does the same thing? *boom* This is why the alter hook is used currently because this is not a theoretical problem at this exact moment.

I agree this is a wider problem & not sure of the fix but if the workaround in #10 is to be used then it should use the key 'token type' (as mentioned in the comment) and not 'token info' (as used in the patch).

Hello,

Thanks for the review, you're right justanothermark, it's 'token type'. I tested at work, and I rewrote a patch at home and I didn't realize I wrote a wrong key.

In the token module in the hook_entity_info_alter :

 // Fill in default token types for entities.
    switch ($entity_type) {
      case 'taxonomy_term':
      case 'taxonomy_vocabulary':
        // Stupid taxonomy token types...
        $info[$entity_type]['token type'] = str_replace('taxonomy_', '', $entity_type);
        break;
      default:
        // By default the token type is the same as the entity type.
        $info[$entity_type]['token type'] = $entity_type;
        break;
    }

So the value should be 'menu_link'.

Here is a patch with the right key and value.

Applying the patch in #15 to the latest dev has caused the notices to cease for me.

Confirming the patch in #15 worked for me, Thank you.

Yeah... contrib projects need to agree amongst themselves who gets to entitize a particular core table. Or declare on their project pages that they're mutually incompatible.

Entitizing (funny word :)) a core table should not be done by some random module that needs to use that data as an entity, because if you try to do it that way then you are relying on some other unrelated module that a user may not want to use.

Ideally it should be in a module that specifically does just the entitizing and then is required by other modules that need it.

So in this case some sort of menu_item_entity module would handle just this entity definition and any other modules that need it require it.

This seems to be kind of what entity_menu_links does although it also has some things that a straight entitizing module doesn't really need, like the UUID/services stuff so it isn't really a candidate for a dependency of xmlsitemap.

The patch in #15 worked for me as well.

Patch #15 works for me.

Committed #15 to 7.x-2.x. Thanks everyone.