Not possible to disable "Save new revision" when enabled by default

Thanks, but this is not the right fix. that call is required for the new revision checkbox to be enabled or not based on the node tape settings.

Yes for example, or just $node->setNewRevision(!empty($form_state['values']['revision']));

Tests and fix looks good, thanks!

Just a bunch of coding style/naming things to fix and then this is ready to go :)

1. +++ b/core/modules/node/lib/Drupal/node/Tests/NodeCreateNewRevisionTest.php
   @@ -0,0 +1,78 @@
   + * Definition of Drupal\node\Tests\NodeRevisionsTest.
   

   Should be Contains of \Drupal\... instead of Definition of...

2. +++ b/core/modules/node/lib/Drupal/node/Tests/NodeCreateNewRevisionTest.php
   @@ -0,0 +1,78 @@
   +/**
   + * Tests the node revision functionality.
   + */
   +class NodeCreateNewRevisionTest extends NodeTestBase {
   

   Should we name this NodeRevisionUiTest or so, to clarify that we're testing the UI unlike the other revision tests? I think it's better to not make this too specific about creating new revisions, as we're actually testing that we're not creating one and might add more tests later on.

3. +++ b/core/modules/node/lib/Drupal/node/Tests/NodeCreateNewRevisionTest.php
   @@ -0,0 +1,78 @@
   +  protected $nodes;
   +  protected $logs;
   

   Seem unused, so can be removed.

4. +++ b/core/modules/node/lib/Drupal/node/Tests/NodeCreateNewRevisionTest.php
   @@ -0,0 +1,78 @@
   +    return array(
   +      'name' => 'Node create new revision',
   +      'description' => "Edit a node with revisions turned on by default and check that revisions are not created if 'Create new revision' option is unchecked.",
   +      'group' => 'Node',
   +    );
   

   Same here, then I'd say name is something "Node revision UI", or maybe Node revision form? class should in that case also be Form instead of Ui.

   The description can be shorter, we might also add more test method to this later for other examples, so make it a bit more generic. "Checks the UI for controlling node revision behavior." or so?

   @inheritdoc should also be added to setUp() and getInfo() now.

5. +++ b/core/modules/node/lib/Drupal/node/Tests/NodeCreateNewRevisionTest.php
   @@ -0,0 +1,78 @@
   +    // Set page revision setting 'create new revision'. This will mean new
   +    // revisions are created by default when the node is edited.
   +    \Drupal::config('node.type.page')->set('settings.node.options.revision', TRUE)->save();
   

   I think this on by default but it makes sense to ensure that anyway. However, we should use the entity API to change a config entity:

   $type = entity_load('node_type', 'page');
   $type->settings['node']['options']['revision'] = TRUE;
   $type->save();
   

   I think...

6. +++ b/core/modules/node/lib/Drupal/node/Tests/NodeCreateNewRevisionTest.php
   @@ -0,0 +1,78 @@
   +    $this->assertFieldChecked('edit-revision', 'create new revision on node edit form checked');
   

   Create... instead of create...

Thanks, looks good. Only nitpick that I was able to find is the missing leading \ in the @file docblock, it should be "Contains \Drupal\node\Tests\NodeRevisionsUiTest".

Also, When updating a patch based on a review, it is very helpful to provide an interdiff, see https://drupal.org/documentation/git/interdiff. That makes it easier for me to verify the changes you made since the last patch.

@marthinal: Yep. There's a patch with only the test in #7, but it would probably make sense to have the final patch as a test-only patch too, to proof that it still fails, but we didn't make any functional changes on the test since then I think.