Problem

  1. drupal_override_server_variables() is supposed to be used before Drupal is bootstrapped.
  2. But yet, the code in D8 tries to retrieve a request from the container in \Drupal.
  3. Logic error: There cannot be a container in \Drupal, if you are supposed to use this function before Drupal is bootstrapped.
  4. The entire function is obsolete in the first place, since the Symfony Request has the same code built-in.

Proposed solution

  1. Remove drupal_override_server_variables().
CommentFileSizeAuthor
#4 drupal8.server-override.4.patch6.4 KBsun
drupal8.server-override.0.patch6.89 KBsun

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

Verified that no version of Drush uses this function either.

Also verified that drush site-install still works with this patch applied, so this seems indeed obsolete.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Thanks, I think I had moved bits of this into the kernel in 2016629 but nice to know its not needed at all

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

drupal8.server-override.0.patch no longer applies.

error: patch failed: core/includes/install.core.inc:281
error: core/includes/install.core.inc: patch does not apply
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll
StatusFileSize
new drupal8.server-override.4.patch6.4 KB
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yeah Request::create() already does this so it is indeed pointless. Also a shame we kept refactoring this function to 'convert' it to Request instead of looking at what it was actually trying to do.

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.