Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views_ui.module
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Anonymous (not verified)
Created:
3 Mar 2014 at 15:04 UTC
Updated:
9 Mar 2022 at 12:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerGood observation!
This should be solvable by a novice. Hint: The file is core/modules/views_ui/lib/Drupal/views_ui/ViewDeleteFormController.php
Comment #2
andrei.dincu commentedComment #3
andrei.dincu commentedHopefully problem solved.
I have added a message with drupal_set_message() function in method submit() from class ViewDeleteFormController.
Comment #4
andrei.dincu commentedComment #5
paulh commentedConfirmed. When a view is deleted, now provided with a response message: View [view_name] deleted
Comment #6
paulh commentedComment #7
paulh commentedI'm not sure if this patch needed to include a test, so I think I pre-empted the 'RTBC' and thus setting back to 'Needs review'.
Comment #8
paulh commentedComment #9
dawehnerYeah let's better add one.
Comment #10
JayeshSolanki commentedPatch applied cleanly.Now it does displays a message when a View is deleted.
Comment #11
miraj9093 commentedwrote test. needs review..
Comment #13
andrei.dincu commentedwrite message and wrote test in Drupal\views_ui\Tests\ViewEditTest
set message View deleted when a view is deleted
needs review
Comment #14
andrei.dincu commentedComment #16
miraj9093 commentedComment #17
dawehnernote: the variable view is not available at that point. you first have to load it, see some lines below.
Comment #19
sidharthapView loaded before the use.
Comment #20
dawehnerThis doesn't work. The test and the end explicitly ensures that deleting the view works. If you have still the old views object in memory this test will fail.
Comment #22
andrei.dincu commentedTests: take 2 view objects ... one before click Delete and the other after.
Comment #23
andrei.dincu commentedComment #25
andrei.dincu commentedreplace assertText with assertRaw in ViewEditTest.php
Comment #26
andrei.dincu commentedComment #27
larowlanThese changes look out of scope?
Other than that, looks RTBC to me :)
Great job!
Comment #28
andrei.dincu commentedfixed #27 problems...hope it works fine
waiting for you review
Comment #29
andrei.dincu commentedComment #30
andrei.dincu commentedComment #31
andrei.dincu commentedhopefully...it works now
Comment #32
andrei.dincu commentedComment #34
larowlanassuming green.
Comment #36
webchickNice UX fix, and tests too! :)
Committed and pushed to 8.x. Thanks!