Comments

dawehner’s picture

Issue tags: +VDC, +Novice

Good observation!

This should be solvable by a novice. Hint: The file is core/modules/views_ui/lib/Drupal/views_ui/ViewDeleteFormController.php

andrei.dincu’s picture

Assigned: Unassigned » andrei.dincu
Status: Active » Needs work
andrei.dincu’s picture

StatusFileSize
new625 bytes
new26.96 KB

Hopefully problem solved.
I have added a message with drupal_set_message() function in method submit() from class ViewDeleteFormController.

andrei.dincu’s picture

Status: Needs work » Needs review
paulh’s picture

Confirmed. When a view is deleted, now provided with a response message: View [view_name] deleted

paulh’s picture

Status: Needs review » Reviewed & tested by the community
paulh’s picture

I'm not sure if this patch needed to include a test, so I think I pre-empted the 'RTBC' and thus setting back to 'Needs review'.

paulh’s picture

Status: Reviewed & tested by the community » Needs review
dawehner’s picture

Status: Needs review » Needs work

Yeah let's better add one.

JayeshSolanki’s picture

Patch applied cleanly.Now it does displays a message when a View is deleted.

miraj9093’s picture

Status: Needs work » Needs review
StatusFileSize
new1.6 KB

wrote test. needs review..

Status: Needs review » Needs work

The last submitted patch, 11: 2209449.4.patch, failed testing.

andrei.dincu’s picture

StatusFileSize
new1.47 KB

write message and wrote test in Drupal\views_ui\Tests\ViewEditTest
set message View deleted when a view is deleted
needs review

andrei.dincu’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: delete-view-2209449-13.patch, failed testing.

miraj9093’s picture

Status: Needs work » Needs review
StatusFileSize
new1.6 KB
dawehner’s picture

+++ b/core/modules/views_ui/lib/Drupal/views_ui/Tests/ViewEditTest.php
@@ -41,7 +41,7 @@ public function testDeleteLink() {
+    $this->assertText(t('View %name deleted', array('%name' => $view->label())));

note: the variable view is not available at that point. you first have to load it, see some lines below.

Status: Needs review » Needs work

The last submitted patch, 16: 2209449.7.patch, failed testing.

sidharthap’s picture

Status: Needs work » Needs review
StatusFileSize
new1.97 KB

View loaded before the use.

dawehner’s picture

This doesn't work. The test and the end explicitly ensures that deleting the view works. If you have still the old views object in memory this test will fail.

Status: Needs review » Needs work

The last submitted patch, 19: 2209449-19.patch, failed testing.

andrei.dincu’s picture

StatusFileSize
new1.78 KB

Tests: take 2 view objects ... one before click Delete and the other after.

andrei.dincu’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 22: delete-view-2209449-22.patch, failed testing.

andrei.dincu’s picture

StatusFileSize
new1.73 KB

replace assertText with assertRaw in ViewEditTest.php

andrei.dincu’s picture

Status: Needs work » Needs review
larowlan’s picture

Status: Needs review » Needs work
+++ b/core/modules/views_ui/lib/Drupal/views_ui/Tests/ViewEditTest.php
@@ -38,12 +38,14 @@ public function testDeleteLink() {
-    $this->assertUrl('admin/structure/views');
     $view = $this->container->get('entity.manager')->getStorageController('view')->load('test_view');
+    $this->assertUrl('admin/structure/views');

These changes look out of scope?

Other than that, looks RTBC to me :)

Great job!

andrei.dincu’s picture

StatusFileSize
new1.63 KB

fixed #27 problems...hope it works fine
waiting for you review

andrei.dincu’s picture

Status: Needs work » Needs review
andrei.dincu’s picture

Status: Needs review » Needs work
andrei.dincu’s picture

StatusFileSize
new1.62 KB

hopefully...it works now

andrei.dincu’s picture

Status: Needs work » Needs review

The last submitted patch, 25: delete-view-2209449-25.patch, failed testing.

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

assuming green.

The last submitted patch, 28: delete-view-2209449-28.patch, failed testing.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice UX fix, and tests too! :)

Committed and pushed to 8.x. Thanks!

  • Commit 565f066 on 8.x by webchick:
    Issue #2209449 by andrei.dincu, miraj9093, sidharthap | ivanjaros: No...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.