Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
tour.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Mar 2014 at 12:55 UTC
Updated:
29 Jul 2014 at 23:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
larowlanAdding tag
Comment #2
larowlanEvery other toolbar item is an a tag, except tour which was a button.
Changing it to an a seems to fix the padding issue.
Tour still works.
before
after
Comment #3
larowlanthere is some css and js in tour that refer to a button element, so will need to update those too
Comment #4
paulh commented- Reviewed code: no obvious issues.
- Applied patch, tested Tour functionality on view: Content and view: Files. Padding issue resolved without impact on Tour functionality.
- Not sure about the ref in comment #3 to css and js and whether that's pertinent to this patch.
Comment #5
nod_tour button is a button, not a link. Let's tweak the CSS to fix this. There is no href,
<a>is not the right tag.Comment #6
lewisnymanYeah we shouldn't rely on a specific element for styling, which is part of out CSS standards. Let's make sure the CSS is generic enough to cover any element we choose, for accessibility reasons.
Comment #7
lewisnymanOk, I tried adding a common class to replace the element selectors. It got kind of hairy because modules seem to pass through the attributes in different structures? I've never heard of
#optionsoutside of the form api...Comment #8
larowlanNo patch?
Comment #9
lewisnymanWhoops
Comment #10
Coornail commentedPatch looks good, it does fix the padding problem.
Comment #12
lewisnyman9: drupal-tour-button-2208731-9.patch queued for re-testing.
Comment #13
lewisnymanBack to RTBC
Comment #15
webchickCommitted and pushed to 8.x. Thanks!
Comment #17
mgifford