Problem/Motivation

If you visit admin/reports/updates you can see error icon is not aligned with "Not supported!" label. Also icon is added using inline images. We should convert it to background image.

Icon Misaligned

Proposed resolution

- Convert icon from inline img to background-image.
- Align icon with label.

Remaining tasks

Check if the same occurs with the other icons (warning and ok).

User interface changes

New icon alignment.

API changes

None.

CommentFileSizeAuthor
#19 2208319-19.png206.27 KBgalooph
#16 snapshot1.png68.47 KBalexrayu
#7 Screenshot 2014-03-24 13.12.10.jpg268.43 KBLewisNyman
#6 drupal-icon_misaligned_in_admin_reports_updates-2208319-06.patch452 bytesvisabhishek
#4 drupal-icon_misaligned_in_admin_reports_updates-2208319-03.patch436 bytesvisabhishek
#2 drupal-icon_misaligned_in_admin_reports_updates-2208319-02.patch409 bytesvisabhishek
icon-missaligned.png117.41 KBrteijeiro
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Assigned: Unassigned » emma.maria
visabhishek’s picture

visabhishek CreditAttribution: visabhishek commented
Status: Active » Needs review
FileSize
drupal-icon_misaligned_in_admin_reports_updates-2208319-02.patch409 bytes

hi,

I have Created a patch to align icon.

rteijeiro’s picture

rteijeiro CreditAttribution: rteijeiro commented
Status: Needs review » Needs work

Thanks @visabhishek. I think when you add some LTR styling you should include the corresponding RTL styling too. Could you do that and check that it's working too for RTL languages, please?

visabhishek’s picture

visabhishek CreditAttribution: visabhishek commented
Status: Needs work » Needs review
FileSize
drupal-icon_misaligned_in_admin_reports_updates-2208319-03.patch436 bytes

Thanks @rteijeiro for reminding me. Updated patch are uploaded.

droplet’s picture

droplet CreditAttribution: droplet commented

Can it add prefix .update .not-supported ?

visabhishek’s picture

visabhishek CreditAttribution: visabhishek commented
FileSize
drupal-icon_misaligned_in_admin_reports_updates-2208319-06.patch452 bytes

Yes droplet, we can add.
updated patch is uploaded.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Reviewed & tested by the community
FileSize
Screenshot 2014-03-24 13.12.10.jpg268.43 KB

This looks a lot better. Thanks.

icon looking great

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: drupal-icon_misaligned_in_admin_reports_updates-2208319-06.patch, failed testing.

rteijeiro’s picture

rteijeiro CreditAttribution: rteijeiro commented

6: drupal-icon_misaligned_in_admin_reports_updates-2208319-06.patch queued for re-testing.

Oostie’s picture

Oostie
Primary language Dutch
Location Kampen
CreditAttribution: Oostie commented

Patch works, but why don't we use the same icon as for error messages?

vastav’s picture

vastav CreditAttribution: vastav commented

patch #6 working fine.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented

@Oostie We will, but there is another issue for that #2207767: Replace watchdog icons with Libricons

emma.maria’s picture

emma.maria
she/her
CreditAttribution: emma.maria commented
Assigned: emma.maria » Unassigned
alexrayu’s picture

alexrayu CreditAttribution: alexrayu commented
Assigned: Unassigned » alexrayu
alexrayu’s picture

alexrayu CreditAttribution: alexrayu commented

Setting the span.icon to float:right has done the job for me.

alexrayu’s picture

alexrayu CreditAttribution: alexrayu commented
FileSize
snapshot1.png68.47 KB

Applied the patch, works.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs work » Reviewed & tested by the community

Sounds like RTBC to me

alexrayu’s picture

alexrayu CreditAttribution: alexrayu commented
Assigned: alexrayu » Unassigned

Should be assigned to visabshek, unassigning.

galooph’s picture

galooph CreditAttribution: galooph commented
FileSize
2208319-19.png206.27 KB

I've just tested the patch from #6 together with the Libricon patch from https://drupal.org/comment/8611021#comment-8611021 and it all looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Nice catch!

Committed and pushed to 8.x. Thanks!

  • Commit 29bfb33 on 8.x by webchick: 
    Issue #2208319 by visabhishek, LewisNyman, galooph, rteijeiro: Icon...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.