Updated: Comment #N

Problem/Motivation

Attempting to see if /forum can be built with views.
Added new view of taxonomy terms in vocabulary 'forum'.
Added new relationship to 'parent term'.
As soon as I add it, get 'Broken missing handler'.

no worky

Proposed resolution

Tests
Fix
Reviews

Remaining tasks

Tests
Fix
Reviews

User interface changes

None

API changes

None

CommentFileSizeAuthor
#14 interdiff.txt841 bytesjibran
#14 2207229-14.patch6.12 KBjibran
#4 taxonomy-parent-relationship-2207229.pass_.patch6.16 KBlarowlan
#4 taxonomy-parent-relationship.2207229.fail_.patch5.81 KBlarowlan
#1 taxonomy-parent-relationship-2207229.patch512 byteslarowlan
Screenshot 2014-02-28 11.23.39.png50.39 KBlarowlan

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
StatusFileSize
new taxonomy-parent-relationship-2207229.patch512 bytes

Here's the fix but nfi how to write a test to verify this.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +VDC
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Pointer/guide for tests: Drupal\user\Tests\Views\AccessRoleUITest and the accompanying views.view.test_access_role.yml

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
StatusFileSize
new taxonomy-parent-relationship.2207229.fail_.patch5.81 KB
new taxonomy-parent-relationship-2207229.pass_.patch6.16 KB

Should be red/green

Status: Needs review » Needs work

The last submitted patch, 4: taxonomy-parent-relationship-2207229.pass_.patch, failed testing.

The last submitted patch, 4: taxonomy-parent-relationship.2207229.fail_.patch, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

4: taxonomy-parent-relationship.2207229.fail_.patch queued for re-testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review

4: taxonomy-parent-relationship-2207229.pass_.patch queued for re-testing.

The last submitted patch, 4: taxonomy-parent-relationship.2207229.fail_.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

I love the fix-to-test lines of code ratio here.

  1. +++ b/core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_parent.yml
@@ -0,0 +1,141 @@
+    position: 1

    We're fixing the exporting in another issue, but this should be position: 0 

  2. +++ b/core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_parent.yml
@@ -0,0 +1,141 @@
+uuid: d267be25-096d-4a80-a704-4bcb5037de14

    Are we putting these in? I can never remember.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

For 2 in #10 no not anymore.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Let's just fix those.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Assigned: Unassigned » jibran

going to fix 10.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Assigned: jibran » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2207229-14.patch6.12 KB
new interdiff.txt841 bytes

Fixes for #10.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 4b6ba9f and pushed to 8.x. Thanks!

  • Commit 4b6ba9f on 8.x by alexpott: 
    Issue #2207229 by larowlan, jibran: Attempt to use 'Parent Term'...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.