Updated: Comment #N

Problem/Motivation

Attempting to see if /forum can be built with views.
Added new view of taxonomy terms in vocabulary 'forum'.
Added new relationship to 'parent term'.
As soon as I add it, get 'Broken missing handler'.

no worky

Proposed resolution

Tests
Fix
Reviews

Remaining tasks

Tests
Fix
Reviews

User interface changes

None

API changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

Status: Active » Needs review
FileSize
512 bytes

Here's the fix but nfi how to write a test to verify this.

larowlan’s picture

Issue tags: +VDC
larowlan’s picture

Pointer/guide for tests: Drupal\user\Tests\Views\AccessRoleUITest and the accompanying views.view.test_access_role.yml

larowlan’s picture

Status: Needs review » Needs work

The last submitted patch, 4: taxonomy-parent-relationship-2207229.pass_.patch, failed testing.

The last submitted patch, 4: taxonomy-parent-relationship.2207229.fail_.patch, failed testing.

larowlan’s picture

larowlan’s picture

Status: Needs work » Needs review

The last submitted patch, 4: taxonomy-parent-relationship.2207229.fail_.patch, failed testing.

tim.plunkett’s picture

I love the fix-to-test lines of code ratio here.

  1. +++ b/core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_parent.yml
    @@ -0,0 +1,141 @@
    +    position: 1
    

    We're fixing the exporting in another issue, but this should be position: 0

  2. +++ b/core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_parent.yml
    @@ -0,0 +1,141 @@
    +uuid: d267be25-096d-4a80-a704-4bcb5037de14
    

    Are we putting these in? I can never remember.

jibran’s picture

For 2 in #10 no not anymore.

dawehner’s picture

Status: Needs review » Needs work

Let's just fix those.

jibran’s picture

Assigned: Unassigned » jibran

going to fix 10.

jibran’s picture

Assigned: jibran » Unassigned
Status: Needs work » Needs review
FileSize
6.12 KB
841 bytes

Fixes for #10.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks!

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4b6ba9f and pushed to 8.x. Thanks!

  • Commit 4b6ba9f on 8.x by alexpott:
    Issue #2207229 by larowlan, jibran: Attempt to use 'Parent Term'...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.