Adapt main Help page (admin/help) so that Available Tours block can be added

Thanks for opening. Are we adding the block here too?

@batigolix - Please see updated patch as #3 patch no longer applies in current code.

I tried creating interdiff but got following error,

$ interdiff adapt-main-help-page-2205713-3.patch adapt-main-help-page-2205713-7.patch > interdiff-2205713-3-7.txt
1 out of 1 hunk FAILED -- saving rejects to file /tmp/interdiff-1.8XlbLw.rej
interdiff: Error applying patch1 to reconstructed file

Test failures seem to be related to the patch, not random test bot problems...

@jhodgdon - I think test failures are meant for the files but not to the section in which we have made changes.

Please see the changes which we have done and the test failures. Both are not related.

7: adapt-main-help-page-2205713-7.patch queued for re-testing.

The test failures are the same this time, so they must be related to this patch?

Doesn't look like that if the test failures are relevant to this patch.

I disagree with #14. I retested and got the same exact test errors, and HEAD is not getting these errors, so I think they must be from this patch?

See also #2374083: Add tours list to admin/help page... This is a new currently sandbox contrib module called Configurable Help, which we hope to add to Core in 8.1.x. It has a hook that allows modules to add sections to the main Help page. I'm planning on adding Tours to it via this hook.

I took a careful look at the latest patch on this issue.

There is one documentation problem, in HelpController:

  /**
-   * Prints a page listing a glossary of Drupal terminology.
+   * Prints the main Help page containing some pointers for how to start using
+   * the website and the list of available Help texts.

This needs to be condensed down to one line. "Texts" is also not a countable noun in English so it should probably be "topics" not "texts".

I'm also not sure that this current patch fixes the stated issue. Putting the text at the top into the controller is an excellent idea, but how exactly does this fix the stated goal of allowing the Available Tours block to be displayed? Maybe we should make this into two separate issues?

The test failures also need to be fixed.

There has been no new work on this issue in quite some time. So I'm assuming the person assigned is no longer being actively pursuing it. Sincere apologies if this is wrong.

I've filed a new meta issue to collect all the problems with the current help system and discuss the best route to fixing them; this issue is being added as Related there, and all of its concerns are listed in the Problem/Motivation section:
#2592487: [meta] Help system overhaul

I've also filed a new issue where I'm working on reorganizing this page that I think will subsume most of this issue:
#2661200: Make admin/help page more flexible, and list tours on it
Possibly I should have used this issue instead but I'm not sure my new issue covers everything here.

That other issue I mentioned in the previous comment is probably/hopefully close to being done. I'm looking for final reviews so we can get it into 8.1.x. If you are interested in this issue, you probably want to look at #2661200: Make admin/help page more flexible, and list tours on it. Thanks!

The other issue is done. I think this is now a duplicate of it, as Tours are now listed on admin/help.

agree